Skip to content

Commit 1bace11

Browse files
authored
Support TypeScript parser in eslint (codesandbox#1991)
* Support TypeScript parser in eslint * Support tsx * Fix eslint errors * Fix config * Remove css prop
1 parent 2792b4f commit 1bace11

File tree

13 files changed

+426
-423
lines changed

13 files changed

+426
-423
lines changed

.eslintrc

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,41 @@
4444
"camelcase": "error",
4545
"react-hooks/rules-of-hooks": "error",
4646
"react-hooks/exhaustive-deps": "warn"
47+
},
48+
"overrides": {
49+
"files": ["**/*.ts", "**/*.tsx"],
50+
"parser": "@typescript-eslint/parser",
51+
"parserOptions": {
52+
"ecmaVersion": 2018,
53+
"sourceType": "module",
54+
"ecmaFeatures": { "jsx": true },
55+
"warnOnUnsupportedTypeScriptVersion": true
56+
},
57+
"plugins": ["@typescript-eslint"],
58+
"rules": {
59+
"default-case": "off",
60+
"no-dupe-class-members": "off",
61+
"@typescript-eslint/no-angle-bracket-type-assertion": "warn",
62+
"no-array-constructor": "off",
63+
"@typescript-eslint/no-array-constructor": "warn",
64+
"@typescript-eslint/no-namespace": "error",
65+
"no-use-before-define": "off",
66+
"@typescript-eslint/no-use-before-define": [
67+
"warn",
68+
{
69+
"functions": false,
70+
"classes": false,
71+
"variables": false,
72+
"typedefs": false
73+
}
74+
],
75+
"no-unused-vars": "off",
76+
"@typescript-eslint/no-unused-vars": [
77+
"warn",
78+
{ "args": "none", "ignoreRestSiblings": true }
79+
],
80+
"no-useless-constructor": "off",
81+
"@typescript-eslint/no-useless-constructor": "warn"
82+
}
4783
}
4884
}

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@
5454
"devDependencies": {
5555
"@types/react": "^16.8.12",
5656
"all-contributors-cli": "^5.4.0",
57-
"babel-eslint": "^8.2.1",
58-
"eslint": "CompuIves/eslint#add/define-parser",
57+
"babel-eslint": "^10.0.1",
58+
"eslint": "5.16.0",
5959
"eslint-config-airbnb": "^15.0.1",
6060
"eslint-config-prettier": "^4.2.0",
6161
"eslint-import-resolver-webpack": "^0.8.1",
@@ -74,6 +74,8 @@
7474
"typescript": "3.3.4000"
7575
},
7676
"dependencies": {
77+
"@typescript-eslint/eslint-plugin": "^1.9.0",
78+
"@typescript-eslint/parser": "^1.9.0",
7779
"opencollective": "^1.0.3"
7880
},
7981
"collective": {

packages/app/src/app/components/CodeEditor/Monaco/workers/fetch-dependency-typings.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -99,17 +99,6 @@ const tempTransformFiles = files => {
9999
return finalObj;
100100
};
101101

102-
const transformFiles = dir =>
103-
dir.files
104-
? dir.files.reduce((prev, next) => {
105-
if (next.type === 'file') {
106-
return { ...prev, [next.path]: next };
107-
}
108-
109-
return { ...prev, ...transformFiles(next) };
110-
}, {})
111-
: {};
112-
113102
const getFileMetaData = (dependency, version, depPath) =>
114103
doFetch(
115104
`https://data.jsdelivr.com/v1/package/npm/${dependency}@${version}/flat`

0 commit comments

Comments
 (0)