Skip to content

Commit 1536e9b

Browse files
author
Ives van Hoorne
committed
Revert "Move eslint to separate file"
This reverts commit 41fb032.
1 parent 41fb032 commit 1536e9b

File tree

4 files changed

+93859
-24
lines changed

4 files changed

+93859
-24
lines changed

src/app/index.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@
3535
ga('send', 'pageview');
3636
</script>
3737
<script src="https://cdn.ravenjs.com/3.14.0/raven.min.js" crossorigin="anonymous"></script>
38+
39+
</script>
3840
</head>
3941

4042
<body style="margin: 0; padding: 0;">

src/app/pages/Sandbox/Editor/Content/subviews/CodeEditor/index.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -244,13 +244,9 @@ export default class CodeEditor extends React.PureComponent {
244244
}
245245

246246
if (preferences.lintEnabled) {
247-
System.import('app/utils/codemirror/eslint-lint')
248-
.then(initializer => {
249-
return initializer.default();
250-
})
251-
.then(() => {
252-
this.codemirror.setOption('lint', true);
253-
});
247+
System.import('app/utils/codemirror/eslint-lint').then(() => {
248+
this.codemirror.setOption('lint', true);
249+
});
254250
} else {
255251
this.codemirror.setOption('lint', false);
256252
}

src/app/utils/codemirror/eslint-lint.js

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import CodeMirror from 'codemirror';
22
import 'codemirror/addon/lint/lint.css';
33
import 'codemirror/addon/lint/lint';
44
import fixer from 'eslint/lib/util/source-code-fixer';
5-
import delay from '../../store/services/delay';
5+
import './eslint';
66

77
const allRules = {
88
'react/jsx-uses-react': require('eslint-plugin-react/lib/rules/jsx-uses-react'),
@@ -68,6 +68,10 @@ const allRules = {
6868
'react/jsx-tag-spacing': require('eslint-plugin-react/lib/rules/jsx-tag-spacing'),
6969
};
7070

71+
try {
72+
eslint.defineRules(allRules);
73+
} catch (e) {}
74+
7175
const defaultConfig = {
7276
extends: ['prettier', 'prettier/react', 'prettier/flowtype'],
7377
parserOptions: {
@@ -1602,19 +1606,4 @@ export function fix(source) {
16021606
return fixer.applyFixes(eslint.getSourceCode(), errors);
16031607
}
16041608

1605-
export default (async function initialize() {
1606-
if (!window.eslint) {
1607-
// Add eslint as script
1608-
const script = document.createElement('script');
1609-
script.setAttribute('src', 'http://eslint.org/js/app/eslint.js');
1610-
script.setAttribute('async', false);
1611-
document.head.appendChild(script);
1612-
}
1613-
1614-
while (!window.eslint) {
1615-
await delay(100);
1616-
}
1617-
1618-
eslint.defineRules(allRules);
1619-
CodeMirror.registerHelper('lint', 'javascript', validator);
1620-
});
1609+
CodeMirror.registerHelper('lint', 'javascript', validator);

0 commit comments

Comments
 (0)