Better detection for text files while uploading

Author: CompuIves

packages/app/package.json

@@ -222,6 +222,7 @@
     "subworkers": "^1.0.1",
     "svg-react-loader": "^0.4.4",
     "tern": "^0.21.0",
+    "textextensions": "^3.3.0",
     "use-interval": "^1.2.1",
     "util": "0.11.1",
     "vue": "^2.5.2",

packages/app/src/app/overmind/namespaces/files/internalActions.ts

@@ -78,6 +78,9 @@ export const uploadFiles: AsyncAction<
   const filePaths = Object.keys(files);
   const chunkedFilePaths = chunk(filePaths, 5);
 
+  const textExtensions = (await import('textextensions/source/index.json'))
+    .default;
+
   // We traverse all files and upload them when necessary, then add them to the
   // parsedFiles object
   /* eslint-disable no-restricted-syntax, no-await-in-loop */
@@ -87,20 +90,10 @@ export const uploadFiles: AsyncAction<
         const file = files[filePath];
         const { dataURI } = file;
 
+        const extension = filePath.split('.').pop();
+
         if (
-          (/\.(j|t)sx?$/.test(filePath) ||
-            /\.coffee$/.test(filePath) ||
-            /\.json$/.test(filePath) ||
-            /\.html$/.test(filePath) ||
-            /\.vue$/.test(filePath) ||
-            /\.styl$/.test(filePath) ||
-            /\.(le|sc|sa)ss$/.test(filePath) ||
-            /\.haml$/.test(filePath) ||
-            /\.pug$/.test(filePath) ||
-            /\.svg$/.test(filePath) ||
-            /\.md$/.test(filePath) ||
-            /\.svelte$/.test(filePath) ||
-            /\.hbs$/.test(filePath) ||
+          (textExtensions.includes(extension) ||
             file.type.startsWith('text/') ||
             file.type === 'application/json') &&
           dataURI.length < MAX_FILE_SIZE

yarn.lock

@@ -28273,6 +28273,11 @@ textextensions@2:
   version "2.2.0"
   resolved "https://registry.yarnpkg.com/textextensions/-/textextensions-2.2.0.tgz#38ac676151285b658654581987a0ce1a4490d286"
 
+textextensions@^3.3.0:
+  version "3.3.0"
+  resolved "https://registry.yarnpkg.com/textextensions/-/textextensions-3.3.0.tgz#03530d5287b86773c08b77458589148870cc71d3"
+  integrity sha512-mk82dS8eRABNbeVJrEiN5/UMSCliINAuz8mkUwH4SwslkNP//gbEzlWNS5au0z5Dpx40SQxzqZevZkn+WYJ9Dw==
+
 textextensions@~1.0.0:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/textextensions/-/textextensions-1.0.2.tgz#65486393ee1f2bb039a60cbba05b0b68bd9501d2"