Skip to content

Commit 0ed9d0b

Browse files
author
Ives van Hoorne
committed
Fix ansi in error details
1 parent d1e7957 commit 0ed9d0b

File tree

2 files changed

+6
-3
lines changed
  • packages/app/src/app
    • components/Preview/DevTools/Tests/TestDetails/ErrorDetails
    • store/modules/files

2 files changed

+6
-3
lines changed

packages/app/src/app/components/Preview/DevTools/Tests/TestDetails/ErrorDetails/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import React from 'react';
22
import styled from 'styled-components';
33
import theme from 'common/theme';
4+
import ansiHTML from 'ansi-html';
45

56
import type { TestError } from '../../';
67

@@ -58,9 +59,11 @@ const formatDiffMessage = (error: TestError, path: string) => {
5859
`<span style="color:${theme.green()}">$1</span>`
5960
)}</span>`;
6061
} else {
61-
finalMessage = error.message + '\n\n' + error.stack;
62+
finalMessage = escapeHtml(error.message + '\n\n' + error.stack);
6263
}
6364

65+
finalMessage = ansiHTML(finalMessage);
66+
6467
if (
6568
error.mappedErrors &&
6669
error.mappedErrors[0] &&

packages/app/src/app/store/modules/files/actions.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -559,8 +559,8 @@ export function recoverFiles({ recover, controller, state }) {
559559
const titleB = `recovered '${module.title}'`;
560560
state.push('editor.tabs', {
561561
type: 'DIFF',
562-
codeA: module.code,
563-
codeB: recoverData.code,
562+
codeA: module.code || '',
563+
codeB: recoverData.code || '',
564564
titleA,
565565
titleB,
566566
fileTitle: module.title,

0 commit comments

Comments
 (0)