Skip to content

Commit da16839

Browse files
refactor: Replace deprecated smart_text with smart_str
1 parent 07e26dd commit da16839

4 files changed

Lines changed: 12 additions & 12 deletions

File tree

ietf/api/serializer.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from django.core.exceptions import ObjectDoesNotExist, FieldError
1010
from django.core.serializers.json import Serializer
1111
from django.http import HttpResponse
12-
from django.utils.encoding import smart_text
12+
from django.utils.encoding import smart_str
1313
from django.db.models import Field
1414
from django.db.models.query import QuerySet
1515
from django.db.models.signals import post_save, post_delete, m2m_changed
@@ -121,7 +121,7 @@ def end_object(self, obj):
121121
for name in expansions:
122122
try:
123123
field = getattr(obj, name)
124-
#self._current["_"+name] = smart_text(field)
124+
#self._current["_"+name] = smart_str(field)
125125
if not isinstance(field, Field):
126126
options = self.options.copy()
127127
options["expand"] = [ v[len(name)+2:] for v in options["expand"] if v.startswith(name+"__") ]
@@ -188,10 +188,10 @@ def handle_fk_field(self, obj, field):
188188
related = related.natural_key()
189189
elif field.remote_field.field_name == related._meta.pk.name:
190190
# Related to remote object via primary key
191-
related = smart_text(related._get_pk_val(), strings_only=True)
191+
related = smart_str(related._get_pk_val(), strings_only=True)
192192
else:
193193
# Related to remote object via other field
194-
related = smart_text(getattr(related, field.remote_field.field_name), strings_only=True)
194+
related = smart_str(getattr(related, field.remote_field.field_name), strings_only=True)
195195
self._current[field.name] = related
196196

197197
def handle_m2m_field(self, obj, field):
@@ -201,7 +201,7 @@ def handle_m2m_field(self, obj, field):
201201
elif self.use_natural_keys and hasattr(field.remote_field.to, 'natural_key'):
202202
m2m_value = lambda value: value.natural_key()
203203
else:
204-
m2m_value = lambda value: smart_text(value._get_pk_val(), strings_only=True)
204+
m2m_value = lambda value: smart_str(value._get_pk_val(), strings_only=True)
205205
self._current[field.name] = [m2m_value(related)
206206
for related in getattr(obj, field.name).iterator()]
207207

@@ -264,6 +264,6 @@ def json_view(self, request, filter=None, expand=None):
264264
qd = dict( ( k, json.loads(v)[0] ) for k,v in items )
265265
except (FieldError, ValueError) as e:
266266
return HttpResponse(json.dumps({"error": str(e)}, sort_keys=True, indent=3), content_type=content_type)
267-
text = json.dumps({smart_text(self.model._meta): qd}, sort_keys=True, indent=3)
267+
text = json.dumps({smart_str(self.model._meta): qd}, sort_keys=True, indent=3)
268268
return HttpResponse(text, content_type=content_type)
269269

ietf/doc/utils_charter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from django.urls import reverse as urlreverse
1313
from django.template.loader import render_to_string
1414
from django.utils import timezone
15-
from django.utils.encoding import smart_text, force_str
15+
from django.utils.encoding import smart_str, force_str
1616

1717
import debug # pyflakes:ignore
1818

@@ -197,7 +197,7 @@ def derive_new_work_text(review_text,group):
197197
'Reply_to':'<iesg@ietf.org>'})
198198
if not addrs.cc:
199199
del m['Cc']
200-
return smart_text(m.as_string())
200+
return smart_str(m.as_string())
201201

202202
def default_review_text(group, charter, by):
203203
now = timezone.now()

ietf/meeting/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from django.contrib import messages
1616
from django.template.loader import render_to_string
1717
from django.utils import timezone
18-
from django.utils.encoding import smart_text
18+
from django.utils.encoding import smart_str
1919

2020
import debug # pyflakes:ignore
2121

@@ -699,7 +699,7 @@ def handle_upload_file(file, filename, meeting, subdir, request=None, encoding=N
699699
)
700700
else:
701701
try:
702-
text = smart_text(text)
702+
text = smart_str(text)
703703
except UnicodeDecodeError as e:
704704
return "Failure trying to save '%s'. Hint: Try to upload as UTF-8: %s..." % (filename, str(e)[:120])
705705
# Whole file sanitization; add back what's missing from a complete

ietf/utils/test_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from django.conf import settings
88
from django.contrib.auth.models import User
99
from django.utils import timezone
10-
from django.utils.encoding import smart_text
10+
from django.utils.encoding import smart_str
1111

1212
import debug # pyflakes:ignore
1313

@@ -38,7 +38,7 @@ def create_person(group, role_name, name=None, username=None, email_address=None
3838
user = User.objects.create(username=username,is_staff=is_staff,is_superuser=is_superuser)
3939
user.set_password(password)
4040
user.save()
41-
person = Person.objects.create(name=name, ascii=unidecode_name(smart_text(name)), user=user)
41+
person = Person.objects.create(name=name, ascii=unidecode_name(smart_str(name)), user=user)
4242
email = Email.objects.create(address=email_address, person=person, origin=user.username)
4343
Role.objects.create(group=group, name_id=role_name, person=person, email=email)
4444
return person

0 commit comments

Comments
 (0)