From 1fa33d8f28c3849f4909d29e4aa2df6cb02334ce Mon Sep 17 00:00:00 2001 From: Kenrick Tandrian Date: Sun, 21 Dec 2025 22:43:04 +0700 Subject: [PATCH 1/3] feat(a11y): santa button should accept aria-expanded --- static/src/elements/santa-button.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/static/src/elements/santa-button.js b/static/src/elements/santa-button.js index 3039decb2..ed51fa316 100644 --- a/static/src/elements/santa-button.js +++ b/static/src/elements/santa-button.js @@ -16,6 +16,7 @@ import {html, LitElement} from 'lit-element'; import {nothing} from 'lit-html'; +import {ifDefined} from 'lit-html/directives/if-defined'; import * as common from '../../src/core/common.js'; import styles from './santa-button.css'; @@ -39,6 +40,7 @@ export class SantaButtonElement extends LitElement { path: {type: String}, color: {type: String}, disabled: {type: Boolean, reflect: true}, + ariaExpanded: {attribute: 'aria-expanded'}, ariaLabel: {reflect: true, attribute: 'aria-label'} }; } @@ -86,6 +88,7 @@ export class SantaButtonElement extends LitElement { class="${this.color || ''}" .disabled=${this.disabled} @click=${this._maybePreventClick} + aria-expanded=${ifDefined(this.ariaExpanded || undefined)} aria-label=${this.ariaLabel || nothing}>${inner}`; } From 177570de03982e37f612971bd5afdd57f35d658d Mon Sep 17 00:00:00 2001 From: Kenrick Tandrian Date: Sun, 21 Dec 2025 22:43:35 +0700 Subject: [PATCH 2/3] feat(a11y): update label and expanded for santa buttons --- static/src/elements/santa-chrome.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/static/src/elements/santa-chrome.js b/static/src/elements/santa-chrome.js index 8059403bf..dc7dbbde6 100644 --- a/static/src/elements/santa-chrome.js +++ b/static/src/elements/santa-chrome.js @@ -15,6 +15,7 @@ */ import {html, LitElement} from 'lit-element'; +import {ifDefined} from 'lit-html/directives/if-defined'; import styles from './santa-chrome.css'; import * as prefix from '../lib/prefix.js'; import './santa-button.js'; @@ -100,7 +101,7 @@ export class SantaChromeElement extends LitElement {
- +
From 597ce303a9e64c0b23cffc8dad5cfb88a9ae717a Mon Sep 17 00:00:00 2001 From: Kenrick Tandrian Date: Sun, 21 Dec 2025 22:54:42 +0700 Subject: [PATCH 3/3] fix(msg): update messages --- _messages/en.json | 2 +- en_src_messages.json | 2 +- static/src/elements/santa-chrome.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/_messages/en.json b/_messages/en.json index 8cff57b25..03e42e1b8 100644 --- a/_messages/en.json +++ b/_messages/en.json @@ -156,7 +156,7 @@ "message": "The Calendar" }, "category_all": { - "message": "View All" + "message": "View All Menu" }, "category_android": { "message": "Android" diff --git a/en_src_messages.json b/en_src_messages.json index 443ab480e..71070ba9d 100644 --- a/en_src_messages.json +++ b/en_src_messages.json @@ -209,7 +209,7 @@ }, "category_all": { "description": "Button text. Category label that shows all games.", - "message": "View All" + "message": "View All Menu" }, "category_android": { "description": "Button text. Category label that shows games available on Android devices.", diff --git a/static/src/elements/santa-chrome.js b/static/src/elements/santa-chrome.js index dc7dbbde6..8f40ed426 100644 --- a/static/src/elements/santa-chrome.js +++ b/static/src/elements/santa-chrome.js @@ -101,7 +101,7 @@ export class SantaChromeElement extends LitElement {
- +