From 3380a2e02e6e8f2312f38f7a5c8b4380f90f5247 Mon Sep 17 00:00:00 2001 From: Kevin Leung Date: Sun, 29 Apr 2018 08:38:47 -0700 Subject: [PATCH 1/2] fix map_creep_spread test in python3 --- test_replays/test_all.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_replays/test_all.py b/test_replays/test_all.py index 0cc12077..d04e2089 100644 --- a/test_replays/test_all.py +++ b/test_replays/test_all.py @@ -431,7 +431,7 @@ def test_lotv_creepTracker(self): for player_id in replay.player: if replay.player[player_id].play_race == "Zerg": - assert replay.player[player_id].max_creep_spread >0 + assert replay.player[player_id].max_creep_spread != 0 assert replay.player[player_id].creep_spread_by_minute def test_lotv_map(self): From a5bfd4392339025675a7eb029d0d72469746a916 Mon Sep 17 00:00:00 2001 From: Kevin Leung Date: Mon, 14 May 2018 16:32:37 -0700 Subject: [PATCH 2/2] commenting a minor inconsistency found in unit tests --- sc2reader/engine/plugins/creeptracker.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sc2reader/engine/plugins/creeptracker.py b/sc2reader/engine/plugins/creeptracker.py index 788f5806..7f35f868 100644 --- a/sc2reader/engine/plugins/creeptracker.py +++ b/sc2reader/engine/plugins/creeptracker.py @@ -77,11 +77,12 @@ def handleEndGame(self, event, replay): if player.play_race[0] == 'Z': self.creepTracker.reduce_cgu_per_minute(player.pid) player.creep_spread_by_minute = self.creepTracker.get_creep_spread_area(player.pid) + # note that player.max_creep_spread may be a tuple or an int if player.creep_spread_by_minute: player.max_creep_spread = max(player.creep_spread_by_minute.items(),key=lambda x:x[1]) else: ## Else statement is for players with no creep spread(ie: not Zerg) - player.max_creep_spread =0 + player.max_creep_spread = 0 except Exception as e: print("Whoa! {}".format(e)) pass