From 97b101e1db62930d342098966ab5eb85e0a05077 Mon Sep 17 00:00:00 2001 From: NumberPigeon Date: Wed, 30 Aug 2023 18:45:15 +0800 Subject: [PATCH 1/2] feat: add region_id attr to Entity --- sc2reader/objects.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sc2reader/objects.py b/sc2reader/objects.py index d6c9491d..1922ccb8 100644 --- a/sc2reader/objects.py +++ b/sc2reader/objects.py @@ -135,6 +135,9 @@ def __init__(self, sid, slot_data): toon_handle = self.toon_handle or "0-S2-0-0" parts = toon_handle.split("-") + #: The Battle.net region id the entity is registered to + self.region_id = int(parts[0]) + #: The Battle.net region the entity is registered to self.region = GATEWAY_LOOKUP[int(parts[0])] From f9678286db9bb5e06d8dc24cf4582650682776a9 Mon Sep 17 00:00:00 2001 From: NumberPigeon <108506296+NumberPigeon@users.noreply.github.com> Date: Thu, 31 Aug 2023 01:18:12 +0800 Subject: [PATCH 2/2] refactor: reuse region_id Co-authored-by: Christian Clauss --- sc2reader/objects.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sc2reader/objects.py b/sc2reader/objects.py index 1922ccb8..1488a088 100644 --- a/sc2reader/objects.py +++ b/sc2reader/objects.py @@ -139,7 +139,7 @@ def __init__(self, sid, slot_data): self.region_id = int(parts[0]) #: The Battle.net region the entity is registered to - self.region = GATEWAY_LOOKUP[int(parts[0])] + self.region = GATEWAY_LOOKUP[self.region_id] #: The Battle.net subregion the entity is registered to self.subregion = int(parts[2])