From 6acc9e10e950cb1a7388c8bd8b6706df8cd8dea9 Mon Sep 17 00:00:00 2001 From: Robert Heine Date: Sun, 7 Aug 2022 14:20:56 -0400 Subject: [PATCH 1/3] adjust attribute to reflect whats being checked --- sc2reader/engine/plugins/context.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sc2reader/engine/plugins/context.py b/sc2reader/engine/plugins/context.py index 1a07ca6c..d047c25f 100644 --- a/sc2reader/engine/plugins/context.py +++ b/sc2reader/engine/plugins/context.py @@ -307,7 +307,7 @@ def handleUnitDoneEvent(self, event, replay): else: self.logger.error( "Unit {} done at {} [{}] before it was started!".format( - event.killer_pid, Length(seconds=event.second), event.frame + event.unit_id, Length(seconds=event.second), event.frame ) ) @@ -323,7 +323,7 @@ def handleUnitPositionsEvent(self, event, replay): else: self.logger.error( "Unit at active_unit index {} moved at {} [{}] but it doesn't exist!".format( - event.killer_pid, Length(seconds=event.second), event.frame + event.unit_index, Length(seconds=event.second), event.frame ) ) From c4dd5da9f3dfd1ac9535b35e8c90f296b1683c36 Mon Sep 17 00:00:00 2001 From: Robert Heine Date: Sun, 7 Aug 2022 17:06:15 -0400 Subject: [PATCH 2/3] unit_index isnt an attribute of an event its a var --- sc2reader/engine/plugins/context.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sc2reader/engine/plugins/context.py b/sc2reader/engine/plugins/context.py index d047c25f..42b03d3d 100644 --- a/sc2reader/engine/plugins/context.py +++ b/sc2reader/engine/plugins/context.py @@ -323,7 +323,7 @@ def handleUnitPositionsEvent(self, event, replay): else: self.logger.error( "Unit at active_unit index {} moved at {} [{}] but it doesn't exist!".format( - event.unit_index, Length(seconds=event.second), event.frame + unit_index, Length(seconds=event.second), event.frame ) ) From 310cb1dba370d5371b31b35273e37e106f0f91ea Mon Sep 17 00:00:00 2001 From: Robert Heine Date: Sun, 7 Aug 2022 17:20:10 -0400 Subject: [PATCH 3/3] change value to better reflect logged error --- sc2reader/engine/plugins/context.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sc2reader/engine/plugins/context.py b/sc2reader/engine/plugins/context.py index 42b03d3d..4adfc0e1 100644 --- a/sc2reader/engine/plugins/context.py +++ b/sc2reader/engine/plugins/context.py @@ -198,7 +198,7 @@ def handleUnitDiedEvent(self, event, replay): else: self.logger.error( "Unable to delete unit index {} at {} [{}], index not active.".format( - event.killer_pid, Length(seconds=event.second), event.frame + event.unit_id_index, Length(seconds=event.second), event.frame ) ) else: