Skip to content

Commit fe86668

Browse files
committed
Remove a couple more defunct replay attributes.
1 parent 52e5be9 commit fe86668

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CHANGELOG.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ CHANGELOG
1818
* LocationAbilityEvent is now TargetPointCommandEvent
1919
* SelfAbilityEvent is now DataCommandEvent
2020
* Removed the defunct replay.player_names attribute.
21+
* Removed the defunct replay.events_by_type attribute.
22+
* Removed the defunct replay.other_people attribute.
23+
2124
* event.name is no longer a class property; it can only be accessed from an event instance.
2225
* PingEvents now have new attributes:
2326
* event.to_all - true if ping seen by all

sc2reader/resources.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ def __init__(self, replay_file, filename=None, load_level=4, engine=sc2reader.en
203203
self.load_level = None
204204

205205
#default values, filled in during file read
206-
self.other_people = set()
207206
self.speed = ""
208207
self.type = ""
209208
self.game_type = ""
@@ -215,7 +214,6 @@ def __init__(self, replay_file, filename=None, load_level=4, engine=sc2reader.en
215214
self.map_hash = ""
216215
self.gateway = ""
217216
self.events = list()
218-
self.events_by_type = defaultdict(list)
219217
self.teams, self.team = list(), dict()
220218

221219
self.player = utils.PersonDict()

0 commit comments

Comments
 (0)