Converted replay.date from string to a datetime and added replay.utc_date

Author: alexhanh

sc2reader/parsers.py

@@ -1,4 +1,5 @@
-from time import ctime
+from math import ceil
+from datetime import datetime
 from collections import defaultdict
 
 from objects import Attribute, Message, Player, Event
@@ -136,7 +137,12 @@ def load(self, replay, filecontents):
 
         replay.map = data[1].decode("hex")
         replay.file_time = data[5]
-        replay.date = ctime( (data[5]-116444735995904000)/10000000 )
+
+        # TODO: This doesn't seem to produce exactly correct results.
+        # This might be due to wrong value of the magic constant 116444735995904000
+        # or rounding errors.
+        replay.date = datetime.fromtimestamp((replay.file_time-116444735995904000)/10000000)
+        replay.utc_date = datetime.utcfromtimestamp((replay.file_time-116444735995904000)/10000000)
 
         replay.details_data = data
 

sc2reader/replay.py

@@ -42,11 +42,12 @@ def __init__(self, replay, partial_parse=True, full_parse=True):
          #Used internally to ensure parse ordering
         self.__parsed = dict(details=False, attributes=False, messages=False, events=False, initdata=False)
 
-        # TODO: Change to something better
+        # TODO: Test EPOCH differences between MacOsX and Windows
         # http://en.wikipedia.org/wiki/Epoch_(reference_date)
         # Notice that Windows and Mac have different EPOCHs, I wonder whether
         # this is different depending on the OS on which the replay was played.
-        self.date = "" # Date when the game was played
+        self.date = None # Date when the game was played in local time
+        self.utc_date = None # Date when the game was played in UTC
 
         #Make sure the file exists and is readable, first and foremost
         if not os.access(self.filename, os.F_OK):

shell.py

@@ -2,8 +2,15 @@
 sys.path.append(os.path.dirname(os.path.abspath(__file__)))
 from sc2reader import Replay
 from mpyq import MPQArchive
+from datetime import datetime
+from time import gmtime
 
 # replay = Replay("1.sc2replay")
 # 
 # print replay.player["Nexpacisor"].avg_apm
-# print replay.player["dblrainbow"].apm
+# print replay.player["dblrainbow"].apm
+
+replay = Replay("f.sc2replay", True, False)
+print replay.date
+print datetime.utcfromtimestamp((replay.file_time-116444735995904000)/10000000)
+print datetime.fromtimestamp((replay.file_time-116444735995904000)/10000000)

test_replays/build17811/info.txt

@@ -1,3 +1,5 @@
+Note: All datetimes in UTC+2
+
 1.SC2Replay
 Date played		20 Feb 2011 22:44:48
 Duration 			32:47

test_replays/test_all.py

@@ -3,6 +3,7 @@
 # Run tests with "py.test" in the project root dir
 import os, sys
 import pytest
+import datetime
 
 sys.path.insert(0, os.path.normpath(os.path.join(os.path.dirname(os.path.abspath(__file__)),"../")))
 
@@ -21,8 +22,7 @@ def test_empty():
 
 def test_standard_1v1():
     replay = Replay("test_replays/build17811/1.SC2Replay")
-
-#    assert replay.date == "20 Feb 2011 22:44:48"
+    
     assert replay.length == (32, 47)
     assert replay.map == "Lost Temple"
     assert replay.build == 17811
@@ -152,3 +152,19 @@ def test_kr_realm_and_tampered_messages():
 
 def test_encrypted():
     replay = Replay("test_replays/build17811/4.SC2Replay")
+
+def test_datetimes():
+    # Ignore seconds in comparisons, because they are off by one what is reported by Windows.
+    # This might be a little nuance worth investigating at some point.
+    
+    # Played at 20 Feb 2011 22:44:48 UTC+2
+    replay = Replay("test_replays/build17811/1.SC2Replay")
+    assert replay.utc_date == datetime.datetime(2011, 2, 20, 20, 44, 47)
+    
+    # Played at 21 Feb 2011 00:42:13 UTC+2
+    replay = Replay("test_replays/build17811/2.SC2Replay")
+    assert replay.utc_date == datetime.datetime(2011, 2, 20, 22, 42, 12)
+    
+    # Played at 25 Feb 2011 16:36:28 UTC+2
+    replay = Replay("test_replays/build17811/3.SC2Replay")
+    assert replay.utc_date == datetime.datetime(2011, 2, 25, 14, 36, 26)