Skip to content

Commit d5c05a4

Browse files
committed
Restrict get_logger to work with classes/functions
Its not used with anything else anyway.
1 parent 2f91892 commit d5c05a4

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

sc2reader/log_utils.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,24 +30,18 @@ def add_log_handler(handler, level='WARN', format=None, datefmt=None):
3030

3131
def get_logger(entity):
3232
"""
33-
Retrieves loggers from the enties fully scoped name. Accepts strings,
34-
classes, and functions.
33+
Retrieves loggers from the enties fully scoped name.
3534
3635
get_logger(Replay) -> sc2reader.replay.Replay
37-
get_logger(__name__) -> sc2reader.utils
3836
get_logger(get_logger) -> sc2reader.utils.get_logger
3937
4038
:param entity: The entity for which we want a logger.
4139
"""
4240
try:
43-
if isinstance(entity, basestring):
44-
return logging.getLogger(entity)
45-
else:
46-
return logging.getLogger(entity.__module__+'.'+entity.__name__)
41+
return logging.getLogger(entity.__module__+'.'+entity.__name__)
4742

4843
except AttributeError as e:
49-
msg = "Cannot retrieve logger for {0}. Only strings, classes, and functions supported."
50-
raise TypeError(msg.format(entity))
44+
raise TypeError("Cannot retrieve logger for {0}.".format(entity))
5145

5246
def loggable(cls):
5347
cls.logger = get_logger(cls)

0 commit comments

Comments
 (0)