Skip to content

Commit b32ae90

Browse files
committed
use the 24764 datapack for WoL post-24764. and a failing test to catch the problem
1 parent 0c70bce commit b32ae90

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

sc2reader/resources.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,8 @@ def register_default_datapacks(self):
569569
self.register_datapack(datapacks['WoL']['17326'], lambda r: r.expansion=='WoL' and 17326 <= r.build < 18092)
570570
self.register_datapack(datapacks['WoL']['18092'], lambda r: r.expansion=='WoL' and 18092 <= r.build < 19458)
571571
self.register_datapack(datapacks['WoL']['19458'], lambda r: r.expansion=='WoL' and 19458 <= r.build < 22612)
572-
self.register_datapack(datapacks['WoL']['22612'], lambda r: r.expansion=='WoL' and 22612 <= r.build)
572+
self.register_datapack(datapacks['WoL']['22612'], lambda r: r.expansion=='WoL' and 22612 <= r.build < 24764)
573+
self.register_datapack(datapacks['HotS']['24764'], lambda r: r.expansion=='WoL' and 24764 <= r.build )
573574
self.register_datapack(datapacks['HotS']['base'], lambda r: r.expansion=='HotS' and r.build < 23925)
574575
self.register_datapack(datapacks['HotS']['23925'], lambda r: r.expansion=='HotS' and 23925 <= r.build < 24247)
575576
self.register_datapack(datapacks['HotS']['24247'], lambda r: r.expansion=='HotS' and 24247 <= r.build <= 24764 )

test_replays/test_all.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,9 @@ def test_clan_players():
251251
replay = sc2reader.load_replay("test_replays/2.0.4.24944/Lunar Colony V.SC2Replay")
252252
assert replay.expansion == 'WoL'
253253
assert len(replay.people) == 4
254+
for obj in replay.objects.values():
255+
assert obj.name != 'Ultralisk'
256+
254257

255258
def test_WoL_204():
256259
replay = sc2reader.load_replay("test_replays/2.0.4.24944/ggtracker_1789768.SC2Replay")

0 commit comments

Comments
 (0)