Skip to content

Commit ac5d29e

Browse files
committed
removed team from actor and changed message.player to message.sender
1 parent 4d1e4c8 commit ac5d29e

File tree

3 files changed

+14
-17
lines changed

3 files changed

+14
-17
lines changed

sc2reader/objects.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,10 @@ def __str__(self):
138138
def __repr__(self):
139139
return str(self)
140140

141-
# TODO: Refactor message.player to message.sender
142141
class Message(object):
143142

144143
def __init__(self, time, player, target, text):
145-
self.time, self.player, self.target, self.text = time, player, target, text
144+
self.time, self.sender, self.target, self.text = time, player, target, text
146145
self.seconds = time/16
147146
self.sent_to_all = (self.target == 0)
148147
self.sent_to_allies = (self.target == 2)
@@ -159,7 +158,6 @@ class Actor(object):
159158
def __init__(self, is_obs):
160159
self.pid = None
161160
self.name = None
162-
self.team = None
163161
self.is_obs = is_obs
164162
self.messages = list()
165163
self.events = list()
@@ -170,7 +168,6 @@ def __init__(self, pid, name):
170168
Actor.__init__(self, True)
171169
self.pid = pid
172170
self.name = name
173-
self.team = 0 # Observers share the fictitious team 0
174171

175172
class Player(Actor):
176173

shell.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@
1010
# print replay.players[0].rgba
1111
# print "%02X%02X%02X" % (replay.players[0].rgba['r'], replay.players[0].rgba['g'], replay.players[0].rgba['b'])
1212

13-
replay = Replay("1.sc2replay")
13+
replay = Replay("13.sc2replay")

test_replays/test_all.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -60,29 +60,29 @@ def test_standard_1v1():
6060

6161
assert len(replay.messages) == 12
6262
assert replay.messages[0].text == "hf"
63-
assert replay.messages[0].player.name == "Emperor"
63+
assert replay.messages[0].sender.name == "Emperor"
6464
assert replay.messages[1].text == "HEYA"
65-
assert replay.messages[1].player.name == "Boom"
65+
assert replay.messages[1].sender.name == "Boom"
6666
assert replay.messages[2].text == "gl hf"
67-
assert replay.messages[2].player.name == "Boom"
67+
assert replay.messages[2].sender.name == "Boom"
6868
assert replay.messages[3].text == "sry for caps"
69-
assert replay.messages[3].player.name == "Boom"
69+
assert replay.messages[3].sender.name == "Boom"
7070
assert replay.messages[4].text == "^^"
71-
assert replay.messages[4].player.name == "Emperor"
71+
assert replay.messages[4].sender.name == "Emperor"
7272
assert replay.messages[5].text == "noppe"
73-
assert replay.messages[5].player.name == "Emperor"
73+
assert replay.messages[5].sender.name == "Emperor"
7474
assert replay.messages[6].text == "you greedy bastard"
75-
assert replay.messages[6].player.name == "Boom"
75+
assert replay.messages[6].sender.name == "Boom"
7676
assert replay.messages[7].text == "ggg"
77-
assert replay.messages[7].player.name == "Boom"
77+
assert replay.messages[7].sender.name == "Boom"
7878
assert replay.messages[8].text == "WG"
79-
assert replay.messages[8].player.name == "Emperor"
79+
assert replay.messages[8].sender.name == "Emperor"
8080
assert replay.messages[9].text == "wg? :)"
81-
assert replay.messages[9].player.name == "Boom"
81+
assert replay.messages[9].sender.name == "Boom"
8282
assert replay.messages[10].text == "wipe"
83-
assert replay.messages[10].player.name == "Emperor"
83+
assert replay.messages[10].sender.name == "Emperor"
8484
assert replay.messages[11].text == "huh?"
85-
assert replay.messages[11].player.name == "Boom"
85+
assert replay.messages[11].sender.name == "Boom"
8686

8787
for msg in replay.messages:
8888
assert msg.sent_to_all == True

0 commit comments

Comments
 (0)