Skip to content

Commit 9d175cf

Browse files
committed
Rework factory internals and clean out interface.
Now all the resources are loaded through the now standard Resource(file) interface. Since all construction logic has moved back into the specific Resource class all replay specific functions have been removed from the SC2Factory. Additionally we are abandoning the listeners model for a more straight foward post-processing plugin model where by the plugin implements a __call__ method, accepts a replay, and makes any modifications it finds are necessary. This is both simpler and more efficient for many post processing tasks.
1 parent c28aa50 commit 9d175cf

File tree

3 files changed

+133
-441
lines changed

3 files changed

+133
-441
lines changed

sc2reader/__init__.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,6 @@
1414
# Expose a nice module level interface
1515
__defaultSC2Reader = factories.SC2Factory()
1616

17-
register_datapack = __defaultSC2Reader.register_datapack
18-
register_listener = __defaultSC2Reader.register_listener
19-
register_reader = __defaultSC2Reader.register_reader
20-
21-
get_listeners = __defaultSC2Reader.get_listeners
22-
get_datapack = __defaultSC2Reader.get_datapack
23-
get_reader = __defaultSC2Reader.get_reader
24-
2517
load_replays = __defaultSC2Reader.load_replays
2618
load_replay = __defaultSC2Reader.load_replay
2719
load_maps = __defaultSC2Reader.load_maps
@@ -33,6 +25,5 @@
3325
load_map_histories = __defaultSC2Reader.load_map_headers
3426
load_map_history = __defaultSC2Reader.load_map_header
3527

36-
3728
configure = __defaultSC2Reader.configure
3829
reset = __defaultSC2Reader.reset

0 commit comments

Comments
 (0)