Skip to content

Commit 8255b73

Browse files
committed
Removes the empty (corrupted) replay file. This should get caught by the header file check in read_header
1 parent b31e497 commit 8255b73

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

test_replays/corrupted/empty.SC2Replay

Whitespace-only changes.

test_replays/test_all.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,6 @@
1010
import sc2reader
1111
from sc2reader.exceptions import ParseError
1212

13-
# Parsing should fail for an empty file.
14-
def test_empty():
15-
# Todo: Are we happy with it raising a ValueError? Should it be rather ParseError or something else?
16-
# Maybe a "production" mode would be nice to have, so that it simply returns a status of the parse without
17-
# raising an exception.
18-
with pytest.raises(ValueError):
19-
sc2reader.read("test_replays/corrupted/empty.SC2Replay")
20-
2113
# Tests for build 17811 replays
2214

2315
def test_standard_1v1():
@@ -184,4 +176,4 @@ def test_datetimes():
184176

185177
# Played at 25 Feb 2011 16:36:28 UTC+2
186178
replay = sc2reader.read("test_replays/1.2.2.17811/3.SC2Replay")
187-
assert replay.utc_date == datetime.datetime(2011, 2, 25, 14, 36, 26)
179+
assert replay.utc_date == datetime.datetime(2011, 2, 25, 14, 36, 26)

0 commit comments

Comments
 (0)