handle 38996

Author: dsjoerg

sc2reader/readers.py

@@ -1833,6 +1833,29 @@ def trigger_ping_event(self, data):
             option=data.read_uint32() - 2147483648,
         )
 
+class GameEventsReader_38996(GameEventsReader_38749):
+
+    def trigger_ping_event(self, data):
+        print('yo')
+        return dict(
+            point=dict(
+                x=data.read_uint32() - 2147483648,
+                y=data.read_uint32() - 2147483648,
+            ),
+            unit_tag=data.read_uint32(),
+            unit_link=data.read_uint16(),
+            unit_control_player_id=(data.read_bits(4) if data.read_bool() else None),
+            unit_upkeep_player_id=(data.read_bits(4) if data.read_bool() else None),
+            unit_position=dict(
+                    x=data.read_bits(20),
+                    y=data.read_bits(20),
+                    z=data.read_bits(32) - 2147483648,
+                ),
+            unit_is_under_construction=data.read_bool(),
+            pinged_minimap=data.read_bool(),
+            option=data.read_uint32() - 2147483648,
+        )
+
 class TrackerEventsReader(object):
 
     def __init__(self):

sc2reader/resources.py

@@ -572,7 +572,8 @@ def register_default_readers(self):
         self.register_reader('replay.game.events', readers.GameEventsReader_34784(), lambda r: 34784 <= r.base_build < 36442)
         self.register_reader('replay.game.events', readers.GameEventsReader_36442(), lambda r: 36442 <= r.base_build < 38215)
         self.register_reader('replay.game.events', readers.GameEventsReader_38215(), lambda r: 38215 <= r.base_build < 38749)
-        self.register_reader('replay.game.events', readers.GameEventsReader_38749(), lambda r: 38749 <= r.base_build)
+        self.register_reader('replay.game.events', readers.GameEventsReader_38749(), lambda r: 38749 <= r.base_build < 38996)
+        self.register_reader('replay.game.events', readers.GameEventsReader_38996(), lambda r: 38996 <= r.base_build)
         self.register_reader('replay.game.events', readers.GameEventsReader_HotSBeta(), lambda r: r.versions[1] == 2 and r.build < 24247)
 
     def register_default_datapacks(self):

test_replays/3.0.0.38996/1.SC2Replay

@@ -455,6 +455,12 @@ def test_38749(self):
         self.assertEqual(replay.expansion, 'HotS')
         replay = sc2reader.load_replay("test_replays/3.0.0.38749/2.SC2Replay")
         self.assertEqual(replay.expansion, 'HotS')
+
+    def test_38996(self):
+        replay = sc2reader.load_replay("test_replays/3.0.0.38996/1.SC2Replay")
+        self.assertEqual(replay.expansion, 'LotV')
+        replay = sc2reader.load_replay("test_replays/3.0.0.38996/2.SC2Replay")
+        self.assertEqual(replay.expansion, 'LotV')
 
 
 class TestGameEngine(unittest.TestCase):