Skip to content

Commit 72c856f

Browse files
committed
Refactor SC2Reader.__init__ code to use reset and configure.
1 parent cfa4b2f commit 72c856f

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

sc2reader/__init__.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,14 @@ class SC2Reader(object):
3232
)
3333

3434
def __init__(self, **options):
35-
self.registered_readers = defaultdict(list)
36-
self.registered_datapacks = list()
37-
self.registered_listeners = defaultdict(list)
35+
self.reset()
3836

39-
self.options = utils.AttributeDict(utils.merged_dict(self.default_options, options))
40-
41-
if self.options.register_defaults:
37+
if options.get('register_defaults',None):
4238
self.register_defaults()
4339

40+
self.configure(**options)
41+
42+
4443
def load_replays(self, replay_collection, options=None, **new_options):
4544
options = options or utils.merged_dict(self.options, new_options)
4645

@@ -168,6 +167,9 @@ def configure(self, **new_options):
168167

169168
def reset(self):
170169
self.options = utils.AttributeDict(self.default_options)
170+
self.registered_readers = defaultdict(list)
171+
self.registered_datapacks = list()
172+
self.registered_listeners = defaultdict(list)
171173

172174
__defaultSC2Reader = SC2Reader()
173175

0 commit comments

Comments
 (0)