Few naming corrections

Author: alexhanh

sc2reader/eventparsers.py

@@ -112,8 +112,8 @@ def load(self, event, bytes):
             for i in range(0, totalUnits):
                 unit_id, use_count = bytes.get_big_int(2), bytes.get_big_int(2)
         else:
-            #We're not byte aligned,  so need do so some bit shifting
-            #This seems like 1000% wrong to me,  but its what the people
+            #We're not byte aligned, so need do so some bit shifting
+            #This seems like 1000% wrong to me, but its what the people
             #at phpsc2replay think it is so I'll deal for now
             tail_mask = 0xFF >> (8-extras)
             head_mask = ~tail_mask & 0xFF
@@ -185,11 +185,11 @@ def load(self, event, bytes):
 
             #Because we went bit by bit the mask is different so we
             #take the deselect bits used on the last_byte,  add the two
-            #bits left bits we've carried down,  we need a mask that long
+            #bits left bits we've carried down, we need a mask that long
             else:
                 mask = (1 << (deselect_count+2)) - 1
 
-        #deselect by byte,  I think (deselect_type & 3 == 3) is deselect all
+        #deselect by byte,I think (deselect_type & 3 == 3) is deselect all
         #and as such probably has a deselect_count always == 0,  not sure though
         else:
             #use the 6 left bits on top and the 2 right bits on bottom
@@ -228,7 +228,7 @@ def load(self, event, bytes):
             #Build the unit_type_id over the next 3 bytes
             byte_list = list()
             for i in range(0, 3):
-                #Swap the bytes,  grab another,  and combine w/ the mask
+                #Swap the bytes, grab another, and combine w/ the mask
                 last_byte, next_byte = next_byte, bytes.get_big_int(1)
                 byte_list.append( combine(last_byte, next_byte) )
             unit_type_id = byte_list[0] << 16 | byte_list[1] << 8 | byte_list[2]

sc2reader/parsers.py

@@ -91,7 +91,7 @@ def load(self, replay, filecontents):
             if player.type == "Computer":
                 player.recorder = False
 
-class attribute_parser_17326(attribute_parser):
+class AttributeParser_17326(attribute_parser):
 	def load_header(self, replay, bytes):
 		bytes.skip(5, byte_code=True)              #Always start with 4 nulls
 		self.count = bytes.get_little_int(4)       #get total attribute count

sc2reader/replay.py

@@ -31,7 +31,12 @@ def __init__(self, replay, partial_parse=True, full_parse=True):
         self.frames = None # Integer representing FPS
 
         # TODO: Change to something better
+        # http://en.wikipedia.org/wiki/Epoch_(reference_date)
+        # Notice that Windows and Mac have different EPOCHs, I wonder whether
+        # this is different depending on the OS on which the replay was played.
         self.date = "" # Date when the game was played
+        
+        
         # TODO: hide this?
         self.files = dict() # From the mpq lib
         # TODO: investigate where this gets set
@@ -79,8 +84,8 @@ def _parse_header(self):
         #Assign all the relevant information to the replay object
         self.build = data[1][4]
         self.versions = (data[1][1], data[1][2], data[1][3], self.build)
-        self.releaseString = "%s.%s.%s.%s" % self.versions
-        self.frames,self.seconds = (data[3], data[3]/16)
+        self.release_string = "%s.%s.%s.%s" % self.versions
+        self.frames, self.seconds = (data[3], data[3]/16)
         self.length = (self.seconds/60, self.seconds%60)
 
     def _parse_details(self):

sc2reader/utils.py

@@ -47,7 +47,7 @@ def get_little(self, number, byte_code=False):
             return result, byte_string 
         return result
 
-    def getString(self, length, byte_code=False):
+    def get_string(self, length, byte_code=False):
         string, bytes = self.get_big(length, byte_code=True)
         if byte_code:
             return string.decode("hex"), bytes