Made the message parsing more resiliant to tampered messages

Author: alexhanh

sc2reader/parsers.py

@@ -178,8 +178,16 @@ def load(self, replay, filecontents):
                     length += 128
 
                 text = bytes.get_string(length)
-                replay.messages.append(Message(time, replay.player[player_id], target, text))
-            
+                try:
+                    replay.messages.append(Message(time, replay.player[player_id], target, text))
+                except KeyError:
+                    # This was added because some replay sites added their own tampered
+                    # messages to replays with non-existent player_id.
+                    #
+                    # This will simply ignore and fail silently if such message is 
+                    # found.
+                    pass
+                
         recorders = [player for player in replay.players if player and player.recorder==True]
         if len(recorders) > 1:
             raise ValueError("There should be 1 and only 1 recorder; %s were found" % len(recorders))

test_replays/test_all.py

@@ -1,4 +1,4 @@
-# encoding: UTF-8
+# Encoding: UTF-8
 
 # Run tests with "py.test" in the project root dir
 import os, sys
@@ -147,6 +147,7 @@ def test_us_realm():
     assert replay.player['ShadesofGray'].url == "http://us.battle.net/sc2/en/profile/2358439/1/ShadesofGray/"
     assert replay.player['reddawn'].url == "http://us.battle.net/sc2/en/profile/2198663/1/reddawn/"
 
+# TODO: Current problem.. both players are set as the recording players
 def test_kr_realm_and_tampered_messages():
     replay = Replay("test_replays/build17811/11.SC2Replay")
     assert replay.player['명지대학교'].url == "http://kr.battle.net/sc2/en/profile/258945/1/명지대학교/"