Merge pull request #196 from cclauss/removestar

Python PEP8: Remove wildcard imports with explicit imports

Author: StoicLoofah

sc2reader/engine/engine.py

@@ -1,5 +1,12 @@
 import collections
-from sc2reader.events import *
+from sc2reader.events import (
+    CommandEvent,
+    ControlGroupEvent,
+    Event,
+    GameEvent,
+    MessageEvent,
+    TrackerEvent,
+)
 from sc2reader.engine.events import InitGameEvent, EndGameEvent, PluginExit
 
 

sc2reader/objects.py

@@ -4,7 +4,7 @@
 
 from sc2reader import utils, log_utils
 from sc2reader.decoders import ByteDecoder
-from sc2reader.constants import *
+from sc2reader.constants import GATEWAY_LOOKUP, LOBBY_PROPERTIES, LOCALIZED_RACES
 
 Location = namedtuple("Location", ["x", "y"])
 

sc2reader/readers.py

@@ -1,10 +1,33 @@
 import struct
 
 from sc2reader.exceptions import ParseError, ReadError
-from sc2reader.objects import *
-from sc2reader.events.game import *
-from sc2reader.events.message import *
-from sc2reader.events.tracker import *
+from sc2reader.objects import Attribute
+from sc2reader.events.game import (
+    CameraEvent,
+    CommandManagerStateEvent,
+    HijackReplayGameEvent,
+    PlayerLeaveEvent,
+    ResourceTradeEvent,
+    SelectionEvent,
+    UpdateTargetPointCommandEvent,
+    UpdateTargetUnitCommandEvent,
+    UserOptionsEvent,
+    create_command_event,
+    create_control_group_event,
+)
+from sc2reader.events.message import ChatEvent, PingEvent, ProgressEvent
+from sc2reader.events.tracker import (
+    PlayerSetupEvent,
+    PlayerStatsEvent,
+    UnitBornEvent,
+    UnitDiedEvent,
+    UnitDoneEvent,
+    UnitInitEvent,
+    UnitOwnerChangeEvent,
+    UnitPositionsEvent,
+    UnitTypeChangeEvent,
+    UpgradeCompleteEvent,
+)
 from sc2reader.utils import DepotFile
 from sc2reader.decoders import BitPackedDecoder, ByteDecoder
 

sc2reader/scripts/sc2replayer.py

@@ -38,7 +38,14 @@ def getch():
 
 import argparse
 import sc2reader
-from sc2reader.events import *
+from sc2reader.events import (
+    CameraEvent,
+    CommandEvent,
+    ControlGroupEvent,
+    GameStartEvent,
+    PlayerLeaveEvent,
+    SelectionEvent,
+)
 
 
 def main():
@@ -100,7 +107,7 @@ def main():
                 or isinstance(event, SelectionEvent)
                 or isinstance(event, PlayerLeaveEvent)
                 or isinstance(event, GameStartEvent)
-                or (args.hotkeys and isinstance(event, HotkeyEvent))
+                or (args.hotkeys and isinstance(event, ControlGroupEvent))
                 or (args.cameras and isinstance(event, CameraEvent))
             ):
                 print(event)