Skip to content

Commit 46be0a4

Browse files
committed
Update the comments to be more inline with reality.
Thanks for the review András.
1 parent b0ca583 commit 46be0a4

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

sc2reader/events.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ def __init__(self, frames, pid, event_type, flags):
110110
super(BetaJoinEvent, self).__init__(frames, pid, event_type)
111111
self.flags = flags
112112

113+
# TODO: András says this is just a leave event and not a win event!
114+
# Investigate
113115
class BetaWinEvent(GameEvent):
114116
name = 'BetaWinEvent'
115117

sc2reader/readers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ def __call__(self, data, replay):
131131
# Name
132132
# BnetData:
133133
# unknown1
134-
# subregion_id
135134
# unknown2
135+
# subregion_id
136136
# bnet_id
137137
# actual_race (Terran, Protoss, Zerg)
138138
# ColorData:
@@ -143,8 +143,8 @@ def __call__(self, data, replay):
143143
# Unknown1
144144
# Unknown2
145145
# handicap (0-100)
146-
# Unknown3
147-
# Result (0,1,2) - Frequently 2, indicating unknown. 1 for win.
146+
# Team Number - according to András
147+
# Result (0,1,2) - (Unknown, Win, Loss), thanks András
148148
# Map
149149
# Unknown1
150150
# Unknown2

sc2reader/resources.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ def createPlayer(pid, pdata, attributes):
365365
elif pdata.result == 2:
366366
player.team.result = "Loss"
367367
else:
368-
pass # We don't need to do anything here?
368+
player.team.result = None
369369

370370
player.pick_race = attributes.get('Race','Unknown')
371371
player.play_race = LOCALIZED_RACES.get(pdata.race, pdata.race)

0 commit comments

Comments
 (0)