Skip to content

Commit 2df3e47

Browse files
committed
Assorted bug fixes related to the last half dozen commits.
1 parent 3c12baa commit 2df3e47

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

sc2reader/__init__.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,12 @@ class SC2Reader(object):
7474

7575
def __init__(self, **options):
7676
self.reset()
77+
self.configure(**options)
7778

78-
if options.get('register_defaults',None):
79+
if self.options.get('register_defaults',None):
7980
self.register_defaults()
8081

81-
self.configure(**options)
82+
8283

8384
def configure(self, **new_options):
8485
"""

sc2reader/objects.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,12 @@ class Attribute(object):
6666
0x0BBB: ("Handicap", None),
6767
0x0BBC: ("Difficulty", DIFFICULTY_CODES),
6868
0x0BC1: ("Category", GAME_TYPE_CODES),
69-
0x07D2: ("Teams1v1", lambda v: int(self.value[0])),
70-
0x07D3: ("Teams2v2", lambda v: int(self.value[0])),
71-
0x07D4: ("Teams3v3", lambda v: int(self.value[0])),
72-
0x07D5: ("Teams4v4", lambda v: int(self.value[0])),
73-
0x07D6: ("TeamsFFA", lambda v: int(self.value[0])),
74-
0x07D7: ("Teams5v5", lambda v: int(self.value[0]))
69+
0x07D2: ("Teams1v1", lambda value: int(value[0])),
70+
0x07D3: ("Teams2v2", lambda value: int(value[0])),
71+
0x07D4: ("Teams3v3", lambda value: int(value[0])),
72+
0x07D5: ("Teams4v4", lambda value: int(value[0])),
73+
0x07D6: ("TeamsFFA", lambda value: int(value[0])),
74+
0x07D7: ("Teams5v5", lambda value: int(value[0]))
7575
}
7676

7777
def __init__(self, data):
@@ -136,7 +136,6 @@ def __init__(self, pid, name):
136136
self.messages = list()
137137
self.events = list()
138138
self.is_human = bool()
139-
self.result = "Unknown"
140139
self.recorder = False # Actual recorder will be determined using the replay.message.events file
141140

142141
class Observer(Person):

sc2reader/replay.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ def load_players(self):
268268
# We know there will be a default region because there must be
269269
# at least 1 human player or we wouldn't have a self.
270270
for player in self.players:
271-
if player.type == 'Computer':
271+
if not player.is_human:
272272
player.region = default_region
273273

274274
# Create observers out of the leftover names gathered from initData
@@ -280,7 +280,7 @@ def load_players(self):
280280
self.person[i+1] = observer
281281

282282
# Miscellaneous people processing
283-
self.humans = filter(lambda p: p.type == 'Human', self.people)
283+
self.humans = filter(lambda p: p.is_human, self.people)
284284

285285
if 'message_events' in self.raw_data:
286286
# Figure out recorder

0 commit comments

Comments
 (0)