correctly handle 38749. test passes now

Author: dsjoerg

sc2reader/readers.py

@@ -1215,14 +1215,6 @@ def trigger_ping_event(self, data):
                 y=data.read_uint32()-2147483648,
             ),
             unit_tag=data.read_uint32(),
-            unit_link=data.read_uint16() if replay.build >= 38749 else None,
-            unit_control_player_id=(data.read_bits(4) if data.read_bool() else None) if replay.build >= 38749 else None,
-            unit_upkeep_player_id=(data.read_bits(4) if data.read_bool() else None) if replay.build >= 38749 else None,
-            unit_position=dict(
-                    x=data.read_bits(20),
-                    y=data.read_bits(20),
-                    z=data.read_bits(32) - 2147483648,
-                ) if replay.build >= 38749 else None,
             pinged_minimap=data.read_bool(),
         )
 
@@ -1820,6 +1812,26 @@ def user_options_event(self, data):
             use_ai_beacons=None,
         )
 
+class GameEventsReader_38749(GameEventsReader_38215):
+
+    def trigger_ping_event(self, data):
+        return dict(
+            point=dict(
+                x=data.read_uint32() - 2147483648,
+                y=data.read_uint32() - 2147483648,
+            ),
+            unit_tag=data.read_uint32(),
+            unit_link=data.read_uint16(),
+            unit_control_player_id=(data.read_bits(4) if data.read_bool() else None),
+            unit_upkeep_player_id=(data.read_bits(4) if data.read_bool() else None),
+            unit_position=dict(
+                    x=data.read_bits(20),
+                    y=data.read_bits(20),
+                    z=data.read_bits(32) - 2147483648,
+                ),
+            pinged_minimap=data.read_bool(),
+            option=data.read_uint32() - 2147483648,
+        )
 
 class TrackerEventsReader(object):
 

sc2reader/resources.py

@@ -1,4 +1,4 @@
-    # -*- coding: utf-8 -*-
+   # -*- coding: utf-8 -*-
 from __future__ import absolute_import, print_function, unicode_literals, division
 
 from collections import defaultdict, namedtuple
@@ -571,7 +571,8 @@ def register_default_readers(self):
         self.register_reader('replay.game.events', readers.GameEventsReader_27950(), lambda r: 27950 <= r.base_build < 34784)
         self.register_reader('replay.game.events', readers.GameEventsReader_34784(), lambda r: 34784 <= r.base_build < 36442)
         self.register_reader('replay.game.events', readers.GameEventsReader_36442(), lambda r: 36442 <= r.base_build < 38215)
-        self.register_reader('replay.game.events', readers.GameEventsReader_38215(), lambda r: 38215 <= r.base_build)
+        self.register_reader('replay.game.events', readers.GameEventsReader_38215(), lambda r: 38215 <= r.base_build < 38749)
+        self.register_reader('replay.game.events', readers.GameEventsReader_38749(), lambda r: 38749 <= r.base_build)
         self.register_reader('replay.game.events', readers.GameEventsReader_HotSBeta(), lambda r: r.versions[1] == 2 and r.build < 24247)
 
     def register_default_datapacks(self):