Details patch that doesn't break old replay builds

Author: GraylinKim

sc2reader/factories.py

@@ -361,7 +361,8 @@ def register_defaults(self):
 
     def register_default_readers(self):
         """Registers factory default readers."""
-        self.register_reader('replay.details', readers.DetailsReader_Base())
+        self.register_reader('replay.details', readers.DetailsReader_Base(), lambda r: r.build < 22612)
+        self.register_reader('replay.details', readers.DetailsReader_22612(), lambda r: r.build >= 22612)
         self.register_reader('replay.initData', readers.InitDataReader_Base())
         self.register_reader('replay.message.events', readers.MessageEventsReader_Base())
         self.register_reader('replay.attributes.events', readers.AttributesEventsReader_Base(), lambda r: r.build <  17326)
@@ -402,4 +403,4 @@ def load_replay(self, replay_file, options=None, **new_options):
         else:
             replay = super(SC2Cache, self).load_replay(replay_file, options=options)
             self.cache.set(replay_file, replay)
-            return replay
+            return replay

sc2reader/objects.py

@@ -8,7 +8,6 @@
 from sc2reader.utils import PersonDict, AttributeDict
 
 Location = namedtuple('Location',('x','y'))
-Details = namedtuple('Details',['players','map','unknown1','unknown2','os','file_time','utc_adjustment','unknown4','unknown5','unknown6','unknown7','unknown8','unknown9','unknown10', 'unknown11'])
 
 MapData = namedtuple('MapData',['unknown','gateway','map_hash'])
 PlayerData = namedtuple('PlayerData',['name','bnet','race','color','unknown1','unknown2','handicap','unknown3','result'])

sc2reader/readers.py

@@ -97,6 +97,7 @@ class AttributesEventsReader_17326(AttributesEventsReader_Base):
 
 
 class DetailsReader_Base(Reader):
+    Details = namedtuple('Details',['players','map','unknown1','unknown2','os','file_time','utc_adjustment','unknown4','unknown5','unknown6','unknown7','unknown8','unknown9','unknown10'])
     def __call__(self, buffer, replay):
         # The entire details file is just a serialized data structure
         #
@@ -159,8 +160,10 @@ def __call__(self, buffer, replay):
 
         # As a final touch, label all extracted information using the Details
         # named tuple from objects.py
-        return Details(*ordered_values(data))
+        return self.Details(*ordered_values(data))
 
+class DetailsReader_22612(DetailsReader_Base):
+    Details = namedtuple('Details',['players','map','unknown1','unknown2','os','file_time','utc_adjustment','unknown4','unknown5','unknown6','unknown7','unknown8','unknown9','unknown10', 'unknown11'])
 
 class MessageEventsReader_Base(Reader):
     def __call__(self, buffer, replay):