workaround for objects that appear in selections but not in tracker events somehow

Author: dsjoerg

sc2reader/engine/plugins/context.py

@@ -85,8 +85,14 @@ def handleSelectionEvent(self, event, replay):
 
             # If we have tracker events, the unit must already exist and must already
             # have the correct unit type.
+            elif unit_id in replay.objects:
+              unit = replay.objects[unit_id]
+
+            # Except when it doesn't.
             else:
-                unit = replay.objects[unit_id]
+              unit = replay.datapack.create_unit(unit_id, unit_type, event.frame)
+              replay.objects[unit_id] = unit
+
 
             # Selection events hold flags on units (like hallucination)
             unit.apply_flags(intra_subgroup_flags)

test_replays/2.0.11.26825/bad_unit_ids_1.SC2Replay

@@ -387,6 +387,11 @@ def test_creepTracker(self):
       assert  replay.player[2].creep_spread_by_minute[420] == 9.4
       assert replay.player[2].creep_spread_by_minute[780] == 22.42
 
+    def test_bad_unit_ids(self):
+      replay = sc2reader.load_replay("test_replays/2.0.11.26825/bad_unit_ids_1.SC2Replay", load_level=4)
+      replay = sc2reader.load_replay("test_replays/2.0.9.26147/bad_unit_ids_2.SC2Replay", load_level=4)
+
+
 
 class TestGameEngine(unittest.TestCase):
     class TestEvent(object):