Factor failed jobs into their own partial

Author: tarcieri

lib/resque/server/views/failed.erb

@@ -20,56 +20,7 @@
 
 <ul class='failed'>
   <% Resque::Failure.each(failed_start_at, failed_per_page, params[:queue], params[:class]) do |id, job| %>
-    <li>
-      <dl>
-        <% if job.nil? %>
-        <dt>Error</dt>
-        <dd>Job <%= id %> could not be parsed; perhaps it contains invalid JSON?</dd>
-        <% else %>
-        <dt>Worker</dt>
-        <dd>
-          <a href="<%= u(:workers, job['worker']) %>"><%= job['worker'].split(':')[0...2].join(':') %></a> on <b class='queue-tag'><%= job['queue'] %></b > at <b><span class="time"><%= Time.parse(job['failed_at']).strftime(failed_date_format) %></span></b>
-          <% if job['retried_at'] %>
-            <div class='retried'>
-              Retried <b><span class="time"><%= Time.parse(job['retried_at']).strftime(failed_date_format) %></span></b>
-              <a href="<%= u "failed/remove/#{id}" %>" class="remove" rel="remove">Remove</a>
-            </div>
-          <% else %>
-            <div class='controls'>
-              <a href="<%= u "failed/requeue/#{id}" %>" rel="retry">Retry</a>
-              or
-              <a href="<%= u "failed/remove/#{id}" %>" rel="remove">Remove</a>
-            </div>
-          <% end %>
-        </dd>
-        <dt>Class</dt>
-        <dd>
-          <% if job['payload'] && job['payload']['class'] %>
-            <a href="<%= u "failed/#{params[:queue]}?class=#{job['payload']['class']}" %>">
-              <code><%= job['payload']['class'] %></code>
-            </a>
-          <% else %>
-            <code>nil</code>
-          <% end %>
-        </dd>
-        <dt>Arguments</dt>
-        <dd><pre><%=h job['payload'] ? show_args(job['payload']['args']) : 'nil' %></pre></dd>
-        <dt>Exception</dt>
-        <dd><code><%= job['exception'] %></code></dd>
-        <dt>Error</dt>
-        <dd class='error'>
-          <% if job['backtrace'] %>
-            <a href="#" class="backtrace"><%= h(job['error']) %></a>
-            <pre style='display:none'><%=h job['backtrace'].join("\n") %></pre>
-          <% else %>
-            <%=h job['error'] %>
-          <% end %>
-        </dd>
-        <% end %>
-      </dl>
-      <div class='r'>
-      </div>
-    </li>
+    <%= partial :failed_job, :id => id, :job => job %>
   <% end %>
 </ul>
 

lib/resque/server/views/failed_job.erb

@@ -0,0 +1,50 @@
+<li>
+  <dl>
+    <% if job.nil? %>
+    <dt>Error</dt>
+    <dd>Job <%= id %> could not be parsed; perhaps it contains invalid JSON?</dd>
+    <% else %>
+    <dt>Worker</dt>
+    <dd>
+      <a href="<%= u(:workers, job['worker']) %>"><%= job['worker'].split(':')[0...2].join(':') %></a> on <b class='queue-tag'><%= job['queue'] %></b > at <b><span class="time"><%= Time.parse(job['failed_at']).strftime(failed_date_format) %></span></b>
+      <% if job['retried_at'] %>
+        <div class='retried'>
+          Retried <b><span class="time"><%= Time.parse(job['retried_at']).strftime(failed_date_format) %></span></b>
+          <a href="<%= u "failed/remove/#{id}" %>" class="remove" rel="remove">Remove</a>
+        </div>
+      <% else %>
+        <div class='controls'>
+          <a href="<%= u "failed/requeue/#{id}" %>" rel="retry">Retry</a>
+          or
+          <a href="<%= u "failed/remove/#{id}" %>" rel="remove">Remove</a>
+        </div>
+      <% end %>
+    </dd>
+    <dt>Class</dt>
+    <dd>
+      <% if job['payload'] && job['payload']['class'] %>
+        <a href="<%= u "failed/#{params[:queue]}?class=#{job['payload']['class']}" %>">
+          <code><%= job['payload']['class'] %></code>
+        </a>
+      <% else %>
+        <code>nil</code>
+      <% end %>
+    </dd>
+    <dt>Arguments</dt>
+    <dd><pre><%=h job['payload'] ? show_args(job['payload']['args']) : 'nil' %></pre></dd>
+    <dt>Exception</dt>
+    <dd><code><%= job['exception'] %></code></dd>
+    <dt>Error</dt>
+    <dd class='error'>
+      <% if job['backtrace'] %>
+        <a href="#" class="backtrace"><%= h(job['error']) %></a>
+        <pre style='display:none'><%=h job['backtrace'].join("\n") %></pre>
+      <% else %>
+        <%=h job['error'] %>
+      <% end %>
+    </dd>
+    <% end %>
+  </dl>
+  <div class='r'>
+  </div>
+</li>