extract hook finding to Resque::Plugin

Author: rcarver

lib/resque.rb

@@ -17,6 +17,7 @@
 require 'resque/stat'
 require 'resque/job'
 require 'resque/worker'
+require 'resque/plugin'
 
 module Resque
   include Helpers

lib/resque/job.rb

@@ -109,10 +109,10 @@ def perform
       job_args = args || []
       job_was_performed = false
 
-      before_hooks  = job.methods.grep(/^before_perform/).sort
-      around_hooks  = job.methods.grep(/^around_perform/).sort
-      after_hooks   = job.methods.grep(/^after_perform/).sort
-      failure_hooks = job.methods.grep(/^on_failure/).sort
+      before_hooks  = Plugin.before_hooks(job)
+      around_hooks  = Plugin.around_hooks(job)
+      after_hooks   = Plugin.after_hooks(job)
+      failure_hooks = Plugin.failure_hooks(job)
 
       begin
         # Execute before_perform hook. Abort the job gracefully if

lib/resque/plugin.rb

@@ -0,0 +1,22 @@
+module Resque
+  module Plugin
+    extend self
+
+    def before_hooks(job)
+      job.methods.grep(/^before_perform/).sort
+    end
+
+    def around_hooks(job)
+      job.methods.grep(/^around_perform/).sort
+    end
+
+    def after_hooks(job)
+      job.methods.grep(/^after_perform/).sort
+    end
+
+    def failure_hooks(job)
+      job.methods.grep(/^on_failure/).sort
+    end
+
+  end
+end

test/plugin_test.rb

@@ -0,0 +1,37 @@
+require File.dirname(__FILE__) + '/test_helper'
+
+context "Resque::Plugin finding hooks" do
+  module SimplePlugin
+    extend self
+    def before_perform1; end
+    def before_perform; end
+    def before_perform2; end
+    def after_perform1; end
+    def after_perform; end
+    def after_perform2; end
+    def perform; end
+    def around_perform1; end
+    def around_perform; end
+    def around_perform2; end
+    def on_failure1; end
+    def on_failure; end
+    def on_failure2; end
+  end
+
+  test "before_perform hooks are found and sorted" do
+    assert_equal ["before_perform", "before_perform1", "before_perform2"], Resque::Plugin.before_hooks(SimplePlugin)
+  end
+
+  test "after_perform hooks are found and sorted" do
+    assert_equal ["after_perform", "after_perform1", "after_perform2"], Resque::Plugin.after_hooks(SimplePlugin)
+  end
+
+  test "around_perform hooks are found and sorted" do
+    assert_equal ["around_perform", "around_perform1", "around_perform2"], Resque::Plugin.around_hooks(SimplePlugin)
+  end
+
+  test "on_failure hooks are found and sorted" do
+    assert_equal ["on_failure", "on_failure1", "on_failure2"], Resque::Plugin.failure_hooks(SimplePlugin)
+  end
+end
+