Skip to content

Commit e6b5f30

Browse files
committed
Job equality was not properly implemented.
1 parent 9776c54 commit e6b5f30

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

HISTORY.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.2.2 (2009-12-08)
2+
3+
* Bugfix: Job equality was not properly implemented.
4+
15
## 1.2.1 (2009-12-07)
26

37
* Added `rake resque:workers` task for starting multiple workers.

lib/resque/job.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def inspect
9696
# Equality
9797
def ==(other)
9898
queue == other.queue &&
99-
payload_class = other.payload_class &&
99+
payload_class == other.payload_class &&
100100
args == other.args
101101
end
102102
end

test/resque_test.rb

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,15 @@
5959
test "jobs can test for equality" do
6060
assert Resque::Job.create(:jobs, 'SomeJob', 20, '/tmp')
6161
assert Resque::Job.create(:jobs, 'some-job', 20, '/tmp')
62-
job = Resque.reserve(:jobs)
63-
assert_equal job, Resque.reserve(:jobs)
62+
assert_equal Resque.reserve(:jobs), Resque.reserve(:jobs)
63+
64+
assert Resque::Job.create(:jobs, 'SomeMethodJob', 20, '/tmp')
65+
assert Resque::Job.create(:jobs, 'SomeJob', 20, '/tmp')
66+
assert_not_equal Resque.reserve(:jobs), Resque.reserve(:jobs)
67+
68+
assert Resque::Job.create(:jobs, 'SomeJob', 20, '/tmp')
69+
assert Resque::Job.create(:jobs, 'SomeJob', 30, '/tmp')
70+
assert_not_equal Resque.reserve(:jobs), Resque.reserve(:jobs)
6471
end
6572

6673
test "can put jobs on a queue by way of a method" do

0 commit comments

Comments
 (0)