Skip to content

Commit 9a59289

Browse files
gohanlondefunkt
authored andcommitted
use Redis::Client#id (newer) or Redis#server (older), depending on whether Redis#server is available (support both redis-rb 2.x and 1.x)
1 parent cea6b3e commit 9a59289

File tree

5 files changed

+17
-8
lines changed

5 files changed

+17
-8
lines changed

lib/resque.rb

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,15 @@ def redis
4949
self.redis
5050
end
5151

52+
def redis_id
53+
# support 1.x versions of redis-rb
54+
if redis.respond_to?(:server)
55+
redis.server
56+
else
57+
redis.client.id
58+
end
59+
end
60+
5261
# The `before_first_fork` hook will be run in the **parent** process
5362
# only once, before forking to run the first job. Be careful- any
5463
# changes you make will be permanent for the lifespan of the
@@ -97,7 +106,7 @@ def after_fork=(after_fork)
97106
end
98107

99108
def to_s
100-
"Resque Client connected to #{redis.server}"
109+
"Resque Client connected to #{redis_id}"
101110
end
102111

103112

@@ -270,7 +279,7 @@ def info
270279
:workers => workers.size.to_i,
271280
:working => working.size,
272281
:failed => Stat[:failed],
273-
:servers => [redis.server],
282+
:servers => [redis_id],
274283
:environment => defined?(RAILS_ENV) ? RAILS_ENV : (ENV['RACK_ENV'] || 'development')
275284
}
276285
end

lib/resque/server.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def show(page, layout = true)
106106
begin
107107
erb page.to_sym, {:layout => layout}, :resque => Resque
108108
rescue Errno::ECONNREFUSED
109-
erb :error, {:layout => false}, :error => "Can't connect to Redis! (#{Resque.redis.server})"
109+
erb :error, {:layout => false}, :error => "Can't connect to Redis! (#{Resque.redis_id})"
110110
end
111111
end
112112

@@ -124,7 +124,7 @@ def show(page, layout = true)
124124
show page
125125
end
126126
end
127-
127+
128128
post "/queues/:id/remove" do
129129
Resque.remove_queue(params[:id])
130130
redirect u('queues')
@@ -150,7 +150,7 @@ def show(page, layout = true)
150150
Resque::Failure.clear
151151
redirect u('failed')
152152
end
153-
153+
154154
get "/failed/requeue/:index" do
155155
Resque::Failure.requeue(params[:index])
156156
if request.xhr?

lib/resque/server/views/layout.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
<div id="footer">
3939
<p>Powered by <a href="http://github.com/defunkt/resque">Resque</a> v<%=Resque::Version%></p>
40-
<p>Connected to Redis namespace <%= Resque.redis.namespace %> on <%=Resque.redis.server%></p>
40+
<p>Connected to Redis namespace <%= Resque.redis.namespace %> on <%=Resque.redis_id%></p>
4141
</div>
4242

4343
</body>

lib/resque/server/views/stats.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
<% elsif params[:id] == 'redis' %>
2424

25-
<h1><%= resque.redis.server %></h1>
25+
<h1><%= resque.redis_id %></h1>
2626
<table class='stats'>
2727
<% for key, value in resque.redis.info.to_a.sort_by { |i| i[0].to_s } %>
2828
<tr>

test/resque_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@
216216
assert_equal 3, stats[:queues]
217217
assert_equal 3, stats[:processed]
218218
assert_equal 1, stats[:failed]
219-
assert_equal ['localhost:9736'], stats[:servers]
219+
assert_equal [Resque.redis.respond_to?(:server) ? 'localhost:9736' : 'redis://localhost:9736/0'], stats[:servers]
220220
end
221221

222222
test "decode bad json" do

0 commit comments

Comments
 (0)