Skip to content

Commit 832fb9d

Browse files
committed
Merge pull request resque#718 from kjwierenga/feature/2-0-dequeue-count-fix
Forward port of fix for Resque.dequeue when removing all jobs of a class.
2 parents 127a972 + f19c564 commit 832fb9d

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

lib/resque.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,11 +324,13 @@ def dequeue(klass, *args)
324324
end
325325
return if before_hooks.any? { |result| result == false }
326326

327-
Job.destroy(queue_from_class(klass), klass, *args)
327+
destroyed = Job.destroy(queue_from_class(klass), klass, *args)
328328

329329
Plugin.after_dequeue_hooks(klass).each do |hook|
330330
klass.send(hook, *args)
331331
end
332+
333+
destroyed
332334
end
333335

334336
# Given a class, try to extrapolate an appropriate queue based on a

test/resque_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,9 @@
8080
assert Resque.enqueue(SomeIvarJob, 20, '/tmp')
8181
assert_equal 5, Resque.size(:ivar)
8282

83-
assert Resque.dequeue(SomeIvarJob, 30, '/tmp')
83+
assert_equal 1, Resque.dequeue(SomeIvarJob, 30, '/tmp')
8484
assert_equal 4, Resque.size(:ivar)
85-
assert Resque.dequeue(SomeIvarJob)
85+
assert_equal 3, Resque.dequeue(SomeIvarJob)
8686
assert_equal 1, Resque.size(:ivar)
8787
end
8888

0 commit comments

Comments
 (0)