Skip to content

Commit 65f7bb0

Browse files
guilleiguarandefunkt
authored andcommitted
Renaming server url method to url_path to avoid conflicting with Sinatra 1.2 url helper
1 parent 855b2e6 commit 65f7bb0

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

lib/resque/server.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@ class Server < Sinatra::Base
1616
alias_method :h, :escape_html
1717

1818
def current_section
19-
url request.path_info.sub('/','').split('/')[0].downcase
19+
url_path request.path_info.sub('/','').split('/')[0].downcase
2020
end
2121

2222
def current_page
23-
url request.path_info.sub('/','')
23+
url_path request.path_info.sub('/','')
2424
end
2525

26-
def url(*path_parts)
26+
def url_path(*path_parts)
2727
[ path_prefix, path_parts ].join("/").squeeze('/')
2828
end
29-
alias_method :u, :url
29+
alias_method :u, :url_path
3030

3131
def path_prefix
3232
request.env['SCRIPT_NAME']
@@ -38,7 +38,7 @@ def class_if_current(path = '')
3838

3939
def tab(name)
4040
dname = name.to_s.downcase
41-
path = url(dname)
41+
path = url_path(dname)
4242
"<li #{class_if_current(path)}><a href='#{path}'>#{name}</a></li>"
4343
end
4444

@@ -127,7 +127,7 @@ def show(page, layout = true)
127127

128128
# to make things easier on ourselves
129129
get "/?" do
130-
redirect url(:overview)
130+
redirect url_path(:overview)
131131
end
132132

133133
%w( overview queues working workers key ).each do |page|
@@ -181,7 +181,7 @@ def show(page, layout = true)
181181
end
182182

183183
get "/stats" do
184-
redirect url("/stats/resque")
184+
redirect url_path("/stats/resque")
185185
end
186186

187187
get "/stats/:id" do

lib/resque/server/views/failed.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<% else %>
2323
<dt>Worker</dt>
2424
<dd>
25-
<a href="<%= url(:workers, job['worker']) %>"><%= job['worker'].split(':')[0...2].join(':') %></a> on <b class='queue-tag'><%= job['queue'] %></b > at <b><span class="time"><%= job['failed_at'] %></span></b>
25+
<a href="<%= u(:workers, job['worker']) %>"><%= job['worker'].split(':')[0...2].join(':') %></a> on <b class='queue-tag'><%= job['queue'] %></b > at <b><span class="time"><%= job['failed_at'] %></span></b>
2626
<% if job['retried_at'] %>
2727
<div class='retried'>
2828
Retried <b><span class="time"><%= job['retried_at'] %></span></b>

lib/resque/server/views/queues.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@
3636
</tr>
3737
<% for queue in resque.queues.sort_by { |q| q.to_s } %>
3838
<tr>
39-
<td class='queue'><a class="queue" href="<%= url "queues/#{queue}" %>"><%= queue %></a></td>
39+
<td class='queue'><a class="queue" href="<%= u "queues/#{queue}" %>"><%= queue %></a></td>
4040
<td class='size'><%= resque.size queue %></td>
4141
</tr>
4242
<% end %>
4343
<tr class="<%= Resque::Failure.count.zero? ? "failed" : "failure" %>">
44-
<td class='queue failed'><a class="queue" href="<%= url :failed %>">failed</a></td>
44+
<td class='queue failed'><a class="queue" href="<%= u :failed %>">failed</a></td>
4545
<td class='size'><%= Resque::Failure.count %></td>
4646
</tr>
4747
</table>

lib/resque/server/views/workers.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,12 @@
9595
</tr>
9696
<% for hostname, workers in worker_hosts.sort_by { |h,w| h } %>
9797
<tr>
98-
<td class='queue'><a class="queue" href="<%= url "workers/#{hostname}" %>"><%= hostname %></a></td>
98+
<td class='queue'><a class="queue" href="<%= u "workers/#{hostname}" %>"><%= hostname %></a></td>
9999
<td class='size'><%= workers.size %></td>
100100
</tr>
101101
<% end %>
102102
<tr class="failed">
103-
<td class='queue failed'><a class="queue" href="<%= url "workers/all" %>">all workers</a></td>
103+
<td class='queue failed'><a class="queue" href="<%= u "workers/all" %>">all workers</a></td>
104104
<td class='size'><%= Resque.workers.size %></td>
105105
</tr>
106106
</table>

0 commit comments

Comments
 (0)