Skip to content

Commit 4eabd83

Browse files
committed
Merge pull request resque#683 from jeremy/minitest-only
Shed test/unit. Use minitest exclusively.
2 parents f1f2559 + 3eb1a52 commit 4eabd83

File tree

4 files changed

+12
-24
lines changed

4 files changed

+12
-24
lines changed

test/redis_queue_test.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
require 'resque/queue'
33

44
describe "Resque::Queue" do
5-
include Test::Unit::Assertions
6-
75
class Thing
86
attr_reader :inside
97

@@ -122,7 +120,7 @@ def == other
122120
queue1 << x
123121
queue1.destroy
124122

125-
assert_raise Resque::QueueDestroyed do
123+
assert_raises Resque::QueueDestroyed do
126124
queue1 << x
127125
end
128126
end

test/resque_test.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
require 'test_helper'
22

33
describe "Resque" do
4-
include Test::Unit::Assertions
5-
64
before do
75
Resque.redis.flushall
86

@@ -115,11 +113,11 @@
115113

116114
assert Resque::Job.create(:jobs, 'SomeMethodJob', 20, '/tmp')
117115
assert Resque::Job.create(:jobs, 'SomeJob', 20, '/tmp')
118-
assert_not_equal Resque.reserve(:jobs), Resque.reserve(:jobs)
116+
refute_equal Resque.reserve(:jobs), Resque.reserve(:jobs)
119117

120118
assert Resque::Job.create(:jobs, 'SomeJob', 20, '/tmp')
121119
assert Resque::Job.create(:jobs, 'SomeJob', 30, '/tmp')
122-
assert_not_equal Resque.reserve(:jobs), Resque.reserve(:jobs)
120+
refute_equal Resque.reserve(:jobs), Resque.reserve(:jobs)
123121
end
124122

125123
it "can put jobs on a queue by way of a method" do

test/test_helper.rb

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
require 'rubygems'
22
require 'timeout'
33
require 'bundler/setup'
4-
5-
$dir = File.dirname(File.expand_path(__FILE__))
6-
$LOAD_PATH.unshift $dir + '/../lib'
7-
$TESTING = true
4+
require 'redis/namespace'
85
require 'minitest/unit'
96
require 'minitest/spec'
10-
require 'test/unit'
117

12-
require 'redis/namespace'
8+
$dir = File.dirname(File.expand_path(__FILE__))
9+
$LOAD_PATH.unshift $dir + '/../lib'
1310
require 'resque'
11+
$TESTING = true
1412

1513
#
1614
# make sure we can run redis
@@ -31,11 +29,7 @@
3129
at_exit do
3230
next if $!
3331

34-
if defined?(MiniTest)
35-
exit_code = MiniTest::Unit.new.run(ARGV)
36-
else
37-
exit_code = Test::Unit::AutoRunner.run
38-
end
32+
exit_code = MiniTest::Unit.new.run(ARGV)
3933

4034
processes = `ps -A -o pid,command | grep [r]edis-test`.split("\n")
4135
pids = processes.map { |process| process.split(" ")[0] }

test/worker_test.rb

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
require 'test_helper'
22

33
describe "Resque::Worker" do
4-
include Test::Unit::Assertions
5-
64
before do
75
Resque.redis = Resque.redis # reset state in Resque object
86
Resque.redis.flushall
@@ -235,7 +233,7 @@ def self.perform
235233
end
236234

237235
it "complains if no queues are given" do
238-
assert_raise Resque::NoQueueError do
236+
assert_raises Resque::NoQueueError do
239237
Resque::Worker.new
240238
end
241239
end
@@ -503,7 +501,7 @@ def self.perform
503501
it "reconnects to redis after fork" do
504502
original_connection = Resque.redis.client.connection.instance_variable_get("@sock")
505503
@worker.work(0)
506-
assert_not_equal original_connection, Resque.redis.client.connection.instance_variable_get("@sock")
504+
refute_equal original_connection, Resque.redis.client.connection.instance_variable_get("@sock")
507505
end
508506

509507
it "will call before_pause before it is paused" do
@@ -594,7 +592,7 @@ def self.perform( run_time, rescue_time=nil )
594592

595593
# ensure the worker is started
596594
start_status = Resque.redis.blpop( 'sigterm-test:start', 5 )
597-
assert_not_nil start_status
595+
refute_nil start_status
598596
child_pid = start_status[1].to_i
599597
assert_operator child_pid, :>, 0
600598

@@ -604,7 +602,7 @@ def self.perform( run_time, rescue_time=nil )
604602

605603
# wait to see how it all came down
606604
result = Resque.redis.blpop( 'sigterm-test:result', 5 )
607-
assert_not_nil result
605+
refute_nil result
608606
assert !result[1].start_with?('Finished Normally'), 'Job Finished normally. Sleep not long enough?'
609607
assert result[1].start_with? 'Caught SignalException', 'Signal exception not raised in child.'
610608

0 commit comments

Comments
 (0)