Skip to content

Commit 4b4f7f2

Browse files
committed
Print a deprecation warning for verbose and very_verbose
This changes the accessor methods for Resque::Worker#verbose and very_verbose to no ops that print a deprecation warning with instructions on how to change the severity level. Hopefully this will help ease the transition for anyone presently relying on these flags.
1 parent 1c46db9 commit 4b4f7f2

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

lib/resque/worker.rb

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,6 @@ class Worker
1111
include Resque::Helpers
1212
include Resque::Logging
1313

14-
# Whether the worker should log basic info to STDOUT
15-
attr_accessor :verbose
16-
17-
# Whether the worker should log lots of info to STDOUT
18-
attr_accessor :very_verbose
19-
2014
# Boolean indicating whether this worker can or can not fork.
2115
# Automatically set if a fork(2) fails.
2216
attr_accessor :cant_fork
@@ -610,5 +604,22 @@ def procline(string)
610604
# Log a message to Resque.logger
611605
alias_method :log, :info
612606
alias_method :log!, :debug
607+
608+
# Deprecated legacy methods for controlling the logging threshhold
609+
# Use Resque.logger.level now, e.g.:
610+
#
611+
# Resque.logger.level = Logger::DEBUG
612+
#
613+
def verbose; logger_severity_deprecation_warning; end
614+
def very_verbose; logger_severity_deprecation_warning; end
615+
def verbose=(_); logger_severity_deprecation_warning; end
616+
def very_verbose=(_); logger_severity_deprecation_warning; end
617+
618+
def logger_severity_deprecation_warning
619+
return if $warned_logger_severity_deprecation
620+
puts "*** DEPRECATION WARNING: Resque::Worker#verbose and #very_verbose are deprecated. Please set Resque.logger.level instead"
621+
$warned_logger_severity_deprecation = true
622+
nil
623+
end
613624
end
614625
end

test/worker_test.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -486,8 +486,6 @@ def info(message); @messages << message; end
486486
alias_method :fatal, :info
487487
end
488488

489-
@worker.very_verbose = true
490-
491489
Resque.logger = DummyLogger.new
492490
begin
493491
@worker.work(0)

0 commit comments

Comments
 (0)