Skip to content

Commit 4763c81

Browse files
committed
deprecation warning for using verbose/very_verbose
1 parent de8cc50 commit 4763c81

File tree

2 files changed

+30
-2
lines changed

2 files changed

+30
-2
lines changed

lib/resque/worker.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -653,8 +653,8 @@ def very_verbose=(value)
653653

654654
def logger_severity_deprecation_warning
655655
return if $warned_logger_severity_deprecation
656-
puts "*** DEPRECATION WARNING: Resque::Worker#verbose and #very_verbose are deprecated. Please set Resque.logger.level instead"
657-
puts "Called from: #{caller[0..5].join("\n\t")}"
656+
Kernel.warn "*** DEPRECATION WARNING: Resque::Worker#verbose and #very_verbose are deprecated. Please set Resque.logger.level instead"
657+
Kernel.warn "Called from: #{caller[0..5].join("\n\t")}"
658658
$warned_logger_severity_deprecation = true
659659
nil
660660
end

test/worker_test.rb

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -732,4 +732,32 @@ def self.perform( run_time, rescue_time=nil )
732732
assert !stderr.match(/^WARNING:/)
733733
end
734734
end
735+
736+
test "displays warning when using verbose" do
737+
stdout, stderr = capture_io { @worker.verbose }
738+
$warned_logger_severity_deprecation = false
739+
740+
assert stderr.match(/WARNING:/)
741+
end
742+
743+
test "displays warning when using verbose=" do
744+
stdout, stderr = capture_io { @worker.verbose = true }
745+
$warned_logger_severity_deprecation = false
746+
747+
assert stderr.match(/WARNING:/)
748+
end
749+
750+
test "displays warning when using very_verbose" do
751+
stdout, stderr = capture_io { @worker.very_verbose }
752+
$warned_logger_severity_deprecation = false
753+
754+
assert stderr.match(/WARNING:/)
755+
end
756+
757+
test "displays warning when using very_verbose=" do
758+
stdout, stderr = capture_io { @worker.very_verbose = true }
759+
$warned_logger_severity_deprecation = false
760+
761+
assert stderr.match(/WARNING:/)
762+
end
735763
end

0 commit comments

Comments
 (0)