always create a new redis connection with Resque.create_connection

Author: hone

lib/resque.rb

@@ -61,9 +61,17 @@ def create_connection(server = Resque.server)
 
       Redis::Namespace.new(namespace, :redis => redis)
     when Redis::Namespace
-      server
+      Redis::Namespace.new(server.namespace,
+        :redis => Redis.new(:host        => server.redis.client.host,
+                            :port        => server.redis.client.port,
+                            :db          => server.redis.client.db,
+                            :thread_safe => true))
     else
-      Redis::Namespace.new(:resque, :redis => server)
+      Redis::Namespace.new(:resque,
+        :redis => Redis.new(:host        => server.client.host,
+                            :port        => server.client.port,
+                            :db          => server.client.db,
+                            :thread_safe => true))
     end
   end
 

resque.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |s|
   s.extra_rdoc_files  = [ "LICENSE", "README.markdown" ]
   s.rdoc_options      = ["--charset=UTF-8"]
 
-  s.add_dependency "redis-namespace", "~> 1.2"
+  s.add_dependency "redis-namespace", "~> 1.2.1"
   s.add_dependency "vegas",           "~> 0.1.2"
   s.add_dependency "sinatra",         ">= 0.9.2"
   s.add_dependency "multi_json",      "~> 1.0"

test/resque_test.rb

@@ -25,7 +25,34 @@
     new_redis = Redis.new(:host => "localhost", :port => 9736)
     new_namespace = Redis::Namespace.new("namespace", :redis => new_redis)
     Resque.redis = new_namespace
-    assert_equal new_namespace, Resque.redis
+
+    assert_equal new_namespace.namespace, Resque.redis.namespace
+    [:db, :host, :port].each do |part|
+      assert_equal new_namespace.redis.client.send(part), Resque.redis.client.send(part)
+    end
+  end
+
+  describe "#create_connection" do
+    it "always creates a new connection with a Redis::Namespace" do
+      new_redis      = Redis.new(:host => "localhost", :port => 9736)
+      namespace      = Redis::Namespace.new("namespace", :redis => new_redis)
+      new_connection = Resque.create_connection(namespace)
+
+      refute_equal namespace, new_connection
+      assert_equal "namespace", new_connection.namespace
+      [:db, :host, :port].each do |part|
+        assert_equal namespace.redis.client.send(part), new_connection.redis.client.send(part)
+      end
+    end
+
+    it "always creates a new connection with a Redis object" do
+      new_redis      = Redis.new(:host => "localhost", :port => 9736)
+      new_connection = Resque.create_connection(new_redis)
+      refute_equal new_connection.redis, new_redis
+      [:db, :host, :port].each do |part|
+        assert_equal new_redis.client.send(part), new_connection.redis.client.send(part)
+      end
+    end
   end
 
   it "can put jobs on a queue" do