don't allow pushing to a Queue after it's been destroyed

Author: hone

lib/resque/queue.rb

@@ -4,6 +4,10 @@
 require 'mutex_m'
 
 module Resque
+  ###
+  # Exception raised when trying to access a queue that's already destroyed
+  class QueueDestroyed < RuntimeError; end
+
   ###
   # A queue interface that quacks like Queue from Ruby's stdlib.
   class Queue
@@ -25,7 +29,10 @@ def initialize name, redis, coder = Marshal
     end
 
     # Add +object+ to the queue
+    # If trying to push to an already destroyed queue, it will raise a Resque::QueueDestroyed exception
     def push object
+      raise QueueDestroyed if destroyed?
+
       synchronize do
         @redis.rpush @redis_name, encode(object)
       end

test/redis_queue_test.rb

@@ -108,6 +108,17 @@ def == other
     assert queue1.destroyed?
   end
 
+  it "can't push to queue after destroying it" do
+    queue1 = q
+    x      = Thing.new
+    queue1 << x
+    queue1.destroy
+
+    assert_raise Resque::QueueDestroyed do
+      queue1 << x
+    end
+  end
+
   def q
     Resque::Queue.new 'foo', Resque.redis
   end