changes based on adding some tests.

Still need more tests, but it's a start

Author: Matt George

pyres/horde.py

@@ -7,6 +7,7 @@
 import time, os, signal
 from pyres.worker import Worker
 from pyres import ResQ
+from pyres.exceptions import NoQueueError
 from pyres.utils import OrderedDict
 import datetime
 
@@ -56,11 +57,12 @@ class Khan(object):
     def __init__(self, pool_size=5, queues=[], server='localhost:6379', password=None):
         #super(Khan,self).__init__(queues=queues,server=server,password=password)
         self._shutdown = False
-        self.pool_size = pool_size
+        self.pool_size = int(pool_size)
         self.queues = queues
         self.server = server
         self.password = password
         self.pid = os.getpid()
+        self.validate_queues()
         if isinstance(server,basestring):
             self.resq = ResQ(server=server, password=password)
         elif isinstance(server, ResQ):
@@ -69,6 +71,11 @@ def __init__(self, pool_size=5, queues=[], server='localhost:6379', password=Non
             raise Exception("Bad server argument")
         #self._workers = list()
 
+    def validate_queues(self):
+        "Checks if a worker is given atleast one queue to work on."
+        if not self.queues:
+            raise NoQueueError("Please give each worker at least one queue.")
+    
     def startup(self):
         self.register_signal_handlers()
         self.register_worker()

tests/test_horde.py

@@ -0,0 +1,17 @@
+from tests import PyResTests, Basic, TestProcess
+from pyres import horde
+import os
+
+class KhanTests(PyResTests):
+    def test_khan_init(self):
+        from pyres.exceptions import NoQueueError
+        self.assertRaises(NoQueueError, horde.Khan, 2, [])
+        self.assertRaises(ValueError, horde.Khan, 'test', ['test'])
+        self.assertRaises(Exception, horde.Khan, 2, ['test'], TestProcess)
+    
+    def test_register_worker(self):
+        khan = horde.Khan(pool_size=1, queues=['basic'])
+        khan.startup()
+        name = "%s:%s" % (os.uname()[1],os.getpid())
+        assert khan.started
+        assert self.redis.sismember('resque:khans',name)