Added global functionality with specs

Author: gazay

lib/gon/base.rb

@@ -3,7 +3,10 @@ module Base
     class << self
 
       def render_data(options)
-        data = Gon.all_variables.merge(Gon.global.all_variables)
+        if Gon.global.all_variables.present?
+          Gon::Request.gon['global'] = Gon.global.all_variables
+        end
+        data = Gon.all_variables
         namespace = options[:namespace] || 'gon'
         start = '<script>window.' + namespace + ' = {};'
         script = ''
@@ -24,8 +27,8 @@ def render_data(options)
 
       def get_controller(options)
         options[:controller] ||
-          @request_env['action_controller.instance'] ||
-          @request_env['action_controller.rescue.response'].
+          Gon::Request.env['action_controller.instance'] ||
+          Gon::Request.env['action_controller.rescue.response'].
           instance_variable_get('@template').
           instance_variable_get('@controller')
       end

lib/gon/global.rb

@@ -31,6 +31,10 @@ def jbuilder(*args)
         store_builder_data 'jbuilder', data, options
       end
 
+      def clear
+        @global_vars = {}
+      end
+
       def inspect
         'Gon'
       end

lib/gon/helpers.rb

@@ -10,6 +10,9 @@ module InstanceMethods
       def include_gon(options = {})
         if variables_for_request_present?
           Gon::Base.render_data(options)
+        elsif Gon.global.all_variables.present?
+          Gon.clear
+          Gon::Base.render_data(options)
         else
           ""
         end

spec/gon/global_spec.rb

@@ -0,0 +1,93 @@
+require 'gon'
+
+describe Gon::Global do
+
+  before(:each) do
+    Gon::Global.clear
+  end
+
+  describe '#all_variables' do
+
+    it 'returns all variables in hash' do
+      Gon.global.a = 1
+      Gon.global.b = 2
+      Gon.global.c = Gon.global.a + Gon.global.b
+      Gon.global.c.should == 3
+      Gon.global.all_variables.should == {'a' => 1, 'b' => 2, 'c' => 3}
+    end
+
+    it 'supports all data types' do
+      Gon.global.clear
+      Gon.global.int = 1
+      Gon.global.float = 1.1
+      Gon.global.string = 'string'
+      Gon.global.array = [ 1, 'string' ]
+      Gon.global.hash_var = { :a => 1, :b => '2'}
+      Gon.global.hash_w_array = { :a => [ 2, 3 ] }
+      Gon.global.klass = Hash
+    end
+
+  end
+
+  describe '#include_gon' do
+
+    before(:each) do
+      Gon.clear
+      Gon.global.clear
+      ActionView::Base.
+        instance_methods.
+        map(&:to_s).
+        include?('include_gon').should == true
+      @base = ActionView::Base.new
+      @base.request = request
+    end
+
+    it 'outputs correct js with an integer' do
+      Gon.global.int = 1
+      @base.include_gon.should == "<script>window.gon = {};" +
+                                    "gon.global={\"int\":1};" +
+                                  "</script>"
+    end
+
+    it 'outputs correct js with an integer and integer in Gon' do
+      Gon::Request.
+        instance_variable_set(:@request_id, request.object_id)
+      Gon.int = 1
+      Gon.global.int = 1
+      @base.include_gon.should == "<script>window.gon = {};" +
+                                    "gon.int=1;" +
+                                    "gon.global={\"int\":1};" +
+                                  "</script>"
+    end
+
+    it 'outputs correct js with a string' do
+      Gon.global.str = %q(a'b"c)
+      @base.include_gon.should == "<script>window.gon = {};" +
+                                    "gon.global={\"str\":\"a'b\\\"c\"};" +
+                                  "</script>"
+    end
+
+    it 'outputs correct js with a script string' do
+      Gon.global.str = %q(</script><script>alert('!')</script>)
+      @base.include_gon.should == "<script>window.gon = {};" +
+                                    "gon.global={\"str\":\"<\\/script><script>alert('!')<\\/script>\"};" +
+                                  "</script>"
+    end
+
+  end
+
+  it 'returns exception if try to set public method as variable' do
+    Gon.global.clear
+    lambda { Gon.global.all_variables = 123 }.should raise_error
+    lambda { Gon.global.rabl = 123 }.should raise_error
+  end
+
+  it 'works fine with rabl and jbuilder' do
+    pending
+  end
+
+  def request
+    @request ||= double 'request', :env => {}
+  end
+
+end