Adds InvalidProfileError to AchievementScraper

Author: cadwallion

lib/bnet_scraper/starcraft2/achievement_scraper.rb

@@ -44,7 +44,11 @@ def scrape
       # retrieves the account's achievements overview page HTML for scraping
       def get_response
         response = Faraday.get "#{profile_url}achievements/"
-        @response = Nokogiri::HTML(response.body) 
+        if response.success?
+          @response = Nokogiri::HTML(response.body) 
+        else
+          raise BnetScraper::InvalidProfileError
+        end
       end
 
       # scrapes the recent achievements from the account's achievements overview page

spec/starcraft2/achievement_scraper_spec.rb

@@ -25,6 +25,12 @@
       subject.should_receive(:scrape_showcase)
       subject.scrape
     end
+
+    it 'should return InvalidProfileError if response is 404' do
+      url = 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/achievements/'
+      scraper = BnetScraper::Starcraft2::AchievementScraper.new(url: url)
+      expect { scraper.scrape }.to raise_error(BnetScraper::InvalidProfileError)
+    end
   end
 
   describe '#scrape_showcase' do

spec/support/load_fakeweb.rb

@@ -10,6 +10,7 @@
 
 FakeWeb.allow_net_connect = false
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/', body: failure_html, status: 404, content_type: 'text/html'
+FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/achievements/', body: failure_html, status: 404, content_type: 'text/html'
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/', body: profile_html, status: 200, content_type: 'text/html'
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/leagues', body: leagues_html, status: 200, content_type: 'text/html'
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/12345',   body: league_html, status: 200, content_type: 'text/html'