Adds conditions for accounts without laddering

Author: cadwallion

lib/bnet_scraper/starcraft2/profile_scraper.rb

@@ -35,7 +35,10 @@ def get_profile_data
         if response.success?
           html = Nokogiri::HTML(response.body)
 
-          @race = html.css("#season-snapshot .module-footer a").first().inner_html()
+          if race_div = html.css("#season-snapshot .module-footer a").first()
+            @race = race_div.inner_html()
+          end
+
           @wins = html.css("#career-stats h2").inner_html()
           @achievement_points = html.css("#profile-header h3").inner_html()
         else

spec/starcraft2/profile_scraper_spec.rb

@@ -36,11 +36,14 @@
       subject.should_receive(:get_profile_data)
       subject.scrape
     end
+
     it 'should call get_league_list' do
       subject.should_receive(:get_league_list)
       subject.scrape
     end
 
+
+
     it 'should call output' do
       subject.should_receive(:output)
       subject.scrape
@@ -50,6 +53,21 @@
       scraper = BnetScraper::Starcraft2::ProfileScraper.new url: 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/'
       expect { scraper.scrape }.to raise_error(BnetScraper::InvalidProfileError)
     end
+
+    context 'account that has not laddered' do
+      let(:scraper) {BnetScraper::Starcraft2::ProfileScraper.new(url: 'http://us.battle.net/sc2/en/profile/3354437/1/ClarkeKent/') }
+      before do
+        scraper.scrape
+      end
+
+      it 'should set nil race' do
+        scraper.race.should be_nil
+      end
+      
+      it 'should have an empty array of leagues' do
+        scraper.leagues.should == []
+      end
+    end
   end
 
   describe '#output' do

spec/support/load_fakeweb.rb

@@ -7,6 +7,8 @@
 matches_html      = File.read File.dirname(__FILE__) + '/matches.html'
 status_html       = File.read File.dirname(__FILE__) + '/status.html'
 failure_html      = File.read File.dirname(__FILE__) + '/failure.html'
+no_ladder_html    = File.read File.dirname(__FILE__) + '/no_ladder.html'
+no_leagues_html   = File.read File.dirname(__FILE__) + '/no_ladder_leagues.html'
 
 FakeWeb.allow_net_connect = false
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/', body: failure_html, status: 404, content_type: 'text/html'
@@ -31,3 +33,5 @@
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/achievements/',  body: achievements_html, status: 200, content_type: 'text/html'
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/matches',        body: matches_html, status: 200, content_type: 'text/html'
 FakeWeb.register_uri :get, 'http://www.teamliquid.net/forum/viewmessage.php?topic_id=138846',    body: status_html, status: 200, content_type: 'text/html'
+FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/3354437/1/ClarkeKent/',          body: no_ladder_html, status: 200, content_type: 'text/html'
+FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/3354437/1/ClarkeKent/ladder/leagues', body: no_leagues_html, status: 200, content_type: 'text/html'