Throw exception if URL is formatted incorrectly

Author: cadwallion

lib/bnet_scraper/starcraft2/base_scraper.rb

@@ -20,11 +20,15 @@ class BaseScraper
       def initialize options = {}
         if options[:url]
           extracted_data = options[:url].match(/http:\/\/(.+)\/sc2\/(.+)\/profile\/(.+)\/(\d{1})\/(.[^\/]+)\//)
-          @region     = REGION_DOMAINS[extracted_data[1]]
-          @bnet_id    = extracted_data[3]
-          @bnet_index = extracted_data[4]
-          @account    = extracted_data[5]
-          @url        = options[:url]
+          if extracted_data
+            @region     = REGION_DOMAINS[extracted_data[1]]
+            @bnet_id    = extracted_data[3]
+            @bnet_index = extracted_data[4]
+            @account    = extracted_data[5]
+            @url        = options[:url]
+          else
+            raise BnetScraper::InvalidProfileError, "URL provided does not match Battle.net format"
+          end
         elsif options[:bnet_id] && options[:account]
           @bnet_id  = options[:bnet_id]
           @account  = options[:account]

spec/starcraft2/base_scraper_spec.rb

@@ -6,6 +6,12 @@
     let(:subject) { scraper_class.new(url: 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/') }
   end
 
+  it 'raises InvalidProfileError on poorly formatted URL' do
+    expect {
+      BnetScraper::Starcraft2::BaseScraper.new url: 'mangled_url'
+    }.to raise_error BnetScraper::InvalidProfileError
+  end
+
   describe '#scrape' do
     it 'should raise an error calling scrape' do
       expect { subject.scrape }.to raise_error NotImplementedError