Adds InvalidProfileError to MatchHistoryScraper

Author: cadwallion

lib/bnet_scraper/starcraft2/match_history_scraper.rb

@@ -29,6 +29,8 @@ def get_response
 
         if @response.success?
           @response = Nokogiri::HTML(@response.body)
+        else
+          raise BnetScraper::InvalidProfileError
         end
       end
 

spec/starcraft2/match_history_scraper_spec.rb

@@ -34,6 +34,12 @@
     it 'should set the match date of each match' do
       subject.matches[0][:date].should == '3/12/2012'
     end
+
+    it 'should raised InvalidProfileError when response is 404' do
+      url = 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/matches'
+      scraper = BnetScraper::Starcraft2::MatchHistoryScraper.new(url: url)
+      expect { scraper.scrape }.to raise_error(BnetScraper::InvalidProfileError)
+    end
   end
 
   describe '#output' do

spec/support/load_fakeweb.rb

@@ -12,6 +12,7 @@
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/', body: failure_html, status: 404, content_type: 'text/html'
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/achievements/', body: failure_html, status: 404, content_type: 'text/html'
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/leagues/12345', body: failure_html, status: 404, content_type: 'text/html'
+FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/matches', body: failure_html, status: 404, content_type: 'text/html'
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/', body: profile_html, status: 200, content_type: 'text/html'
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/leagues', body: leagues_html, status: 200, content_type: 'text/html'
 FakeWeb.register_uri :get, 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/12345',   body: league_html, status: 200, content_type: 'text/html'