[Issue GerryFerdinandus#23] Upload trackers to newTrackon

All the trackers in 'Present trackers in all torrent files.'
will be uploaded.
This will reduce the manual labour of copy and paste to newTrackon.

Author: GerryFerdinandus

source/code/controler_trackerlist_online.pas

@@ -12,7 +12,7 @@ interface
 
 type
 
-  TDefaultChecked = function(const TrackerURL: UTF8String): Boolean of object;
+  TDefaultChecked = function(const TrackerURL: UTF8String): boolean of object;
 
   { TControlerTrackerListOnline }
 
@@ -45,9 +45,14 @@   TControlerTrackerListOnline = class
     //must be called if the tracker list is updated
     procedure UpdateView;
 
-    function DownloadTrackers: boolean;
+    function DownloadTrackers_All_Live_Stable: boolean;
 
-    constructor Create(StringGridTorrentURL: TStringGrid; TrackerList: TStringList; DefaultChecked: TDefaultChecked);
+    //Submit tracker to newTrackon via http POST
+    function SubmitTrackers(TrackerList: TStringList;
+      out TrackersSendCount: integer): boolean;
+
+    constructor Create(StringGridTorrentURL: TStringGrid; TrackerList: TStringList;
+      DefaultChecked: TDefaultChecked);
     destructor Destroy; override;
   end;
 
@@ -59,13 +64,19 @@ implementation
 { TControlerTrackerListOnline }
 
 
-function TControlerTrackerListOnline.DownloadTrackers: boolean;
+function TControlerTrackerListOnline.DownloadTrackers_All_Live_Stable: boolean;
 begin
-  Result := FNewTrackon.DownloadTrackers;
+  Result := FNewTrackon.Download_All_Live_Stable;
   UpdateView;
   ShowTrackerStatus(Result);
 end;
 
+function TControlerTrackerListOnline.SubmitTrackers(TrackerList: TStringList;
+  out TrackersSendCount: integer): boolean;
+begin
+  Result := FNewTrackon.SubmitTrackers(TrackerList, TrackersSendCount);
+end;
+
 constructor TControlerTrackerListOnline.Create(StringGridTorrentURL: TStringGrid;
   TrackerList: TStringList; DefaultChecked: TDefaultChecked);
 begin
@@ -177,7 +188,8 @@ procedure TControlerTrackerListOnline.UpdateView;
   //Show the TrackerList list in string grid view
   for tracker in FTrackerList do
   begin
-    AppendRow(FDefaultChecked(tracker), FTrackerListOnline.TrackerStatus(tracker), tracker);
+    AppendRow(FDefaultChecked(tracker), FTrackerListOnline.TrackerStatus(
+      tracker), tracker);
   end;
 
   //make sure all text are fit inside the columns

source/code/main.lfm

@@ -375,6 +375,10 @@ object FormTrackerModify: TFormTrackerModify
         Caption = 'Append Stable Trackers (From newTrackon)'
         OnClick = MenuItemOnlineCheckAppendStableTrackersClick
       end
+      object MenuItemOnlineCheckSubmitNewTrackon: TMenuItem
+        Caption = 'Upload trackers to newTrackon'
+        OnClick = MenuItemOnlineCheckSubmitNewTrackonClick
+      end
     end
     object MenuHelp: TMenuItem
       Caption = '&Help'

source/code/main.pas

@@ -39,6 +39,7 @@   TFormTrackerModify = class(TForm)
     MenuFileTorrentFolder: TMenuItem;
     MenuFileOpenTrackerList: TMenuItem;
     MenuHelpReportingIssue: TMenuItem;
+    MenuItemOnlineCheckSubmitNewTrackon: TMenuItem;
     MenuItemOnlineCheckAppendStableTrackers: TMenuItem;
     MenuTrackersDeleteDeadTrackers: TMenuItem;
     MenuTrackersDeleteUnstableTrackers: TMenuItem;
@@ -95,6 +96,7 @@   TFormTrackerModify = class(TForm)
     procedure FormShow(Sender: TObject);
     procedure MenuHelpReportingIssueClick(Sender: TObject);
     procedure MenuHelpVisitWebsiteClick(Sender: TObject);
+    procedure MenuItemOnlineCheckSubmitNewTrackonClick(Sender: TObject);
 
     //Popup menu in treeview show all/hide all/ individual items selection.
     procedure MenuItemTorrentFilesTreeShowAllClick(Sender: TObject);
@@ -328,6 +330,33 @@ procedure TFormTrackerModify.MenuHelpVisitWebsiteClick(Sender: TObject);
   OpenURL('https://github.com/GerryFerdinandus/bittorrent-tracker-editor');
 end;
 
+procedure TFormTrackerModify.MenuItemOnlineCheckSubmitNewTrackonClick(Sender: TObject);
+var
+  SendStatus: boolean;
+  TrackerSendCount: integer;
+  PopupStr: string;
+begin
+
+  SendStatus := FControlerTrackerListOnline.SubmitTrackers(
+    FTrackerList.TrackerFromInsideTorrentFilesList, TrackerSendCount);
+
+  if SendStatus then
+  begin
+    //Succesful upload
+    PopupStr := format('Successful upload of %d unique tracker URL',[TrackerSendCount]);
+    Application.MessageBox(
+      PChar(@PopupStr[1]),
+      '', MB_ICONINFORMATION + MB_OK);
+  end
+  else
+  begin
+    //something is wrong with uploading
+    Application.MessageBox(
+      PChar('Can not uploading the tracker list'),
+      '', MB_ICONINFORMATION + MB_OK);
+  end;
+end;
+
 procedure TFormTrackerModify.MenuItemOnlineCheckAppendStableTrackersClick(
   Sender: TObject);
 var
@@ -362,7 +391,7 @@ procedure TFormTrackerModify.MenuItemOnlineCheckDownloadNewTrackonClick(
 begin
   try
     screen.Cursor := crHourGlass;
-    FDownloadStatus := FControlerTrackerListOnline.DownloadTrackers;
+    FDownloadStatus := FControlerTrackerListOnline.DownloadTrackers_All_Live_Stable;
   finally
     screen.Cursor := crDefault;
   end;

source/code/newtrackon.pas

@@ -29,11 +29,9 @@ interface
   TNewTrackon = class
   private
     FTRackerList: array [TNewTrackon_List] of TStringList;
-    FDownloadStatus: boolean;
 
-    procedure DownloadTracker(NewTrackon_List: TNewTrackon_List);
+    function DownloadTracker(NewTrackon_List: TNewTrackon_List): boolean;
     procedure CreateTrackerList_Dead;
-
   public
     // all known trackers, dead or alive
     property TrackerList_All: TStringList read FTRackerList[ntl_URL_All];
@@ -53,8 +51,15 @@   TNewTrackon = class
     // trackers that no longer present in 'live' list
     property TrackerList_Dead: TStringList read FTrackerList[ntl_CREATE_DEAD];
 
-    //Download all the trackers via API
-    function DownloadTrackers: boolean;
+    //Download all the types the trackers via API
+    function DownloadEverything: boolean;
+
+    //Download only three types of the trackers via API
+    function Download_All_Live_Stable: boolean;
+
+    //Submit tracker to newTrackon via http POST
+    function SubmitTrackers(TrackerList: TStringList;
+      out TrackersSendCount: integer): boolean;
 
     //create/destroy class object
     constructor Create;
@@ -65,7 +70,7 @@   TNewTrackon = class
 
 implementation
 
-uses fphttpclient, LazUTF8, torrent_miscellaneous;
+uses fphttpclient, LazUTF8, torrent_miscellaneous, httpdefs;
 
 const
   URL: array [TNewTrackon_List] of string =
@@ -80,47 +85,129 @@ implementation
 
 { TNewTrackon }
 
+
 procedure TNewTrackon.CreateTrackerList_Dead;
 begin
   //FTrackerList_Dead = FTrackerList_All - FTrackerList_Live;
   TrackerList_Dead.Assign(TrackerList_All);
   RemoveTrackersFromList(TrackerList_Live, TrackerList_Dead);
 end;
 
-procedure TNewTrackon.DownloadTracker(NewTrackon_List: TNewTrackon_List);
+function TNewTrackon.DownloadTracker(NewTrackon_List: TNewTrackon_List): boolean;
 begin
-  if NewTrackon_List = ntl_CREATE_DEAD then
-    Exit; //there is no Dead tracker list to be downloaded
 
-  //download via URL and put the data in the TrackerList
-  //will create exception if something is wrong
-  FTRackerList[NewTrackon_List].DelimitedText :=
-    TFPCustomHTTPClient.SimpleGet(URL[NewTrackon_List]);
+  try
+    //there is no Dead tracker list to be downloaded. so it can be skip
+    if NewTrackon_List <> ntl_CREATE_DEAD then
+    begin
+      //download via URL and put the data in the TrackerList
+      //will create exception if something is wrong
+      FTRackerList[NewTrackon_List].DelimitedText :=
+        TFPCustomHTTPClient.SimpleGet(URL[NewTrackon_List]);
+    end;
 
-  //Clean up the tracker list
+    Result := True;
+  except
+    //No OpenSSL or web server is down
+    Result := False;
+  end;
+
+  //Clean up the tracker list just downloaded
   SanatizeTrackerList(FTRackerList[NewTrackon_List]);
 end;
 
-function TNewTrackon.DownloadTrackers: boolean;
+function TNewTrackon.DownloadEverything: boolean;
 var
   i: TNewTrackon_List;
 begin
-  try
-    //download all the list one by one
-    for i in TNewTrackon_List do
+  //download all the list one by one
+  for i in TNewTrackon_List do
+  begin
+    Result := DownloadTracker(i);
+    if not Result then
+      Exit;
+  end;
+
+  CreateTrackerList_Dead;
+end;
+
+function TNewTrackon.Download_All_Live_Stable: boolean;
+begin
+  Result := DownloadTracker(ntl_URL_All);
+  if Result then
+  begin
+    Result := DownloadTracker(ntl_URL_Stable);
+    if Result then
     begin
-      DownloadTracker(i);//< may create exception
+      Result := DownloadTracker(ntl_URL_Live);
     end;
+  end;
 
-    CreateTrackerList_Dead;
+  CreateTrackerList_Dead;
+end;
 
-    FDownloadStatus := True;
-  except
-    //No OpenSSL or web server is down
-    FDownloadStatus := False;
-  end;
+function TNewTrackon.SubmitTrackers(TrackerList: TStringList;
+  out TrackersSendCount: integer): boolean;
+var
+  TrackerListToBeSend: TStringList;
+  FormData: string;
+  Trackers: string;
+  HTTPS: TFPHTTPClient;
+  Seperator: string;
+
+const
+  URL_POST = 'https://newtrackon.com/api/add';
+begin
+  TrackersSendCount := 0;
 
-  Result := FDownloadStatus;
+  //Must always first download the ALL tracker list if not already downloaded.
+  //To make sure it is always checking agains the most recent list
+  Result := DownloadTracker(ntl_URL_All);
+
+  if Result then
+  begin
+    try
+      HTTPS := TFPHTTPClient.Create(nil);
+      TrackerListToBeSend := TStringList.Create;
+      TrackerListToBeSend.Assign(TrackerList);
+
+      //remove all duplicate trackers before sending,
+      RemoveTrackersFromList(TrackerList_All, TrackerListToBeSend);
+
+      //Give information back about how many unique tracker URL is send.
+      TrackersSendCount := TrackerListToBeSend.Count;
+
+      if TrackersSendCount > 0 then
+      begin
+
+        //this is the 'key'
+        FormData := 'new_trackers=';
+
+        //This is the 'values' all seperated with one space '+'
+        Seperator := '';
+        for Trackers in TrackerListToBeSend do
+        begin
+          FormData := FormData + Seperator + HTTPEncode(Trackers);
+          if Seperator = '' then
+            Seperator := '+';
+        end;
+
+        try
+          HTTPS.FormPost(URL_POST, FormData);
+
+          //Check the response must be 204
+          Result := HTTPS.ResponseStatusCode = 204;
+        except
+          //No OpenSSL or web server is down
+          Result := False;
+        end;
+      end;
+
+    finally
+      TrackerListToBeSend.Free;
+      HTTPS.Free;
+    end;
+  end;
 end;
 
 constructor TNewTrackon.Create;