Skip to content

Commit ca88435

Browse files
author
Diego Rodríguez Baquero
committed
fix: if websocket closed, don't produce a response
1 parent 4699cc2 commit ca88435

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

lib/server/swarm.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ class Swarm {
4242
self._onAnnounceStarted(params, peer, id)
4343
} else if (params.event === 'stopped') {
4444
self._onAnnounceStopped(params, peer, id)
45+
if (!cb) return // when websocket is closed
4546
} else if (params.event === 'completed') {
4647
self._onAnnounceCompleted(params, peer, id)
4748
} else if (params.event === 'update') {

server.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,7 @@ class Server extends EventEmitter {
588588
event: 'stopped',
589589
numwant: 0,
590590
peer_id: socket.peerId
591-
}, noop)
591+
})
592592
}
593593
})
594594
}

test/request-handler.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ function testRequestHandler (t, serverType) {
1414
class Swarm extends Server.Swarm {
1515
announce (params, cb) {
1616
super.announce(params, (err, response) => {
17-
if (err) return cb(response)
17+
if (cb && err) return cb(response)
1818
response.complete = 246
1919
response.extraData = 'hi'
20-
cb(null, response)
20+
if (cb) cb(null, response)
2121
})
2222
}
2323
}

0 commit comments

Comments
 (0)