Refactoring - removed not used default parameters from constructors.

Author: anuko

WEB-INF/lib/form/Checkbox.class.php

@@ -32,10 +32,9 @@ class Checkbox extends FormElement {
   var $checked = false;
     var $mOptions	= null;
 
-  function __construct($name, $value = '') {
+  function __construct($name) {
     $this->class = 'Checkbox';
     $this->name = $name;
-    $this->value = $value;
   }
 
 	function setChecked($value) { $this->checked = $value; }

WEB-INF/lib/form/CheckboxGroup.class.php

@@ -38,10 +38,9 @@ class CheckboxGroup extends FormElement {
     var $lSelAll	= "All";
     var $lSelNone	= "None";
 
-  function __construct($name, $value = '') {
+  function __construct($name) {
     $this->class = 'CheckboxGroup';
     $this->name = $name;
-    $this->value = $value;
   }
 
 	function setChecked($value)	{ $this->mChecked = $value; }

WEB-INF/lib/form/Combobox.class.php

@@ -45,10 +45,9 @@ class Combobox extends FormElement {
     var $mDataDeep = 1;
     var $mDataKeys = array();
 
-  function __construct($name, $value = '') {
+  function __construct($name) {
     $this->class = 'Combobox';
     $this->name = $name;
-    $this->value = $value;
   }
 
 	function setMultiple($value)	{ $this->mMultiple = $value; }

WEB-INF/lib/form/Form.class.php

@@ -85,7 +85,7 @@ function addInput($params) {
       case 'checkbox':
         import('form.Checkbox');
         $el = new Checkbox($params['name']);
-        if (isset($params['checked'])) $el->setChecked(true);
+        if (isset($params['checked'])) $el->setChecked($params['checked']);
 
 // TODO: refactoring ongoing down from here.
 			    $el->setData(@$params["data"]);

WEB-INF/lib/form/Hidden.class.php

@@ -30,10 +30,9 @@
 
 class Hidden extends FormElement {
 
-  function __construct($name, $value = '') {
+  function __construct($name) {
     $this->class = 'Hidden';
     $this->name = $name;
-    $this->value = $value;
   }
 
   function getHtml() {

WEB-INF/lib/form/PasswordField.class.php

@@ -30,11 +30,10 @@
 
 class PasswordField extends FormElement {
 
-  function __construct($name, $value='')
+  function __construct($name)
   {
     $this->class = 'PasswordField';
     $this->name = $name;
-    $this->value = $value;
   }
 
   function getHtml() {

WEB-INF/lib/form/Submit.class.php

@@ -30,11 +30,10 @@
 
 class Submit extends FormElement {
 
-  function __construct($name, $value = '')
+  function __construct($name)
   {
     $this->class = 'Submit';
     $this->name = $name;
-    $this->value = $value;
   }
 
   function getHtml() {

WEB-INF/lib/form/Table.class.php

@@ -46,10 +46,9 @@ class Table extends FormElement {
   var $mHeaderOptions = array();
   var $mProccessed    = false;
 
-  function __construct($name, $value='') {
+  function __construct($name) {
     $this->class = 'Table';
     $this->name = $name;
-    $this->value = $value;
   }
 
   function setKeyField($value) {

WEB-INF/lib/form/TextArea.class.php

@@ -33,13 +33,12 @@ class TextArea extends FormElement {
     var $mRows		= "";
     var $mOnKeyPress	= "";
 
-  function __construct($name, $value = '')
+  function __construct($name)
   {
     $this->class = 'TextArea';
     $this->name = $name;
-    $this->value = $value;
   }
-	
+
 	function setColumns($value)	{ $this->mColumns = $value;	}
 	function getColumns()	{ return $this->mColumns; }
 

WEB-INF/lib/form/TextField.class.php

@@ -30,11 +30,10 @@
 
 class TextField extends FormElement {
 
-  function __construct($name, $value = '')
+  function __construct($name)
   {
     $this->class = 'TextField';
     $this->name = $name;
-    $this->value = $value;
   }
 
   // TODO: refactoring ongoing down from here.