[Feature] refactored server search and show an initial list (alexjustesen#458)

Author: alexjustesen

app/Filament/Pages/Settings/GeneralPage.php

@@ -86,28 +86,61 @@ protected function getFormSchema(): array
                                     ->multiple()
                                     ->maxItems(10)
                                     ->searchable()
-                                    ->getSearchResultsUsing(function (string $search) {
-                                        $url = "https://www.speedtest.net/api/js/servers?engine=js&search={$search}&https_functional=true&limit=10";
-
-                                        $response = Http::get($url);
+                                    ->options(function () {
+                                        $response = Http::get(
+                                            url: 'https://www.speedtest.net/api/js/servers',
+                                            query: [
+                                                'engine' => 'js',
+                                                'https_functional' => true,
+                                                'limit' => 10,
+                                            ]
+                                        );
+
+                                        if ($response->failed()) {
+                                            return [
+                                                '' => 'There was an error retrieving Speedtest servers',
+                                            ];
+                                        }
 
-                                        $options = $response->collect()->map(function ($item) {
+                                        return $response->collect()->map(function ($item) {
                                             return [
                                                 'id' => $item['id'],
                                                 'name' => $item['id'].': '.$item['name'].' ('.$item['sponsor'].')',
                                             ];
-                                        });
+                                        })->pluck('name', 'id');
+                                    })
+                                    ->getSearchResultsUsing(function (string $search) {
+                                        $response = Http::get(
+                                            url: 'https://www.speedtest.net/api/js/servers',
+                                            query: [
+                                                'engine' => 'js',
+                                                'search' => $search,
+                                                'https_functional' => true,
+                                                'limit' => 10,
+                                            ]
+                                        );
+
+                                        if ($response->failed()) {
+                                            return [
+                                                '' => 'There was an error retrieving Speedtest servers',
+                                            ];
+                                        }
 
-                                        if (! $options->count() && is_numeric($search)) {
-                                            $options = collect([
+                                        if (! $response->collect()->count() && is_numeric($search)) {
+                                            return collect([
                                                 [
                                                     'id' => $search,
                                                     'name' => $search.': No server found, manually add this ID.',
                                                 ],
                                             ]);
                                         }
 
-                                        return $options->pluck('name', 'id');
+                                        return $response->collect()->map(function ($item) {
+                                            return [
+                                                'id' => $item['id'],
+                                                'name' => $item['id'].': '.$item['name'].' ('.$item['sponsor'].')',
+                                            ];
+                                        })->pluck('name', 'id');
                                     })
                                     ->columnSpan(2),
                             ])