Skip to content

Commit 86e0bf2

Browse files
committed
Stopped using grunt-browserify's alias option as it created a global require variable
1 parent 4d18af3 commit 86e0bf2

9 files changed

Lines changed: 19 additions & 33 deletions

File tree

Gruntfile.js

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -82,20 +82,6 @@ module.exports = function(grunt) {
8282

8383
browserify: {
8484
dist: {
85-
options: {
86-
alias: [
87-
'src/js/lib/identifiers.js:identifiers',
88-
'src/js/lib/helpers.js:helpers',
89-
'src/js/payload.js:payload',
90-
'src/js/lib/cookie.js:cookie',
91-
'src/js/lib/detectors.js:detectors',
92-
'src/js/lib/jstz.js:jstz',
93-
'src/js/queue.js:queue',
94-
'src/js/lib/sha1.js:sha1',
95-
'src/js/tracker.js:tracker',
96-
'src/js/snowplow.js:snowplow'
97-
]
98-
},
9985
files: {
10086
'dist/bundle.js': ['src/js/init.js']
10187
}

src/js/init.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,5 @@
3535
// Snowplow Asynchronous Queue
3636
window._snaq = window._snaq || [];
3737

38-
var snowplow = require('snowplow');
38+
var snowplow = require('./snowplow.js');
3939
window.Snowplow = window.Snowplow || new snowplow.Snowplow();

src/js/lib/detectors.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@
3434

3535
;(function() {
3636

37-
var identifiers = require('identifiers');
38-
var helpers = require('helpers');
37+
var identifiers = require('./identifiers.js');
38+
var helpers = require('./helpers.js');
3939
var murmurhash3_32_gc = require('murmurhash').v3;
40+
var tz = require('./jstz.js').determine();
4041

4142
var object = typeof module.exports != 'undefined' ? module.exports : this; // For eventual node.js environment support
4243

@@ -123,8 +124,7 @@
123124
*/
124125
object.detectTimezone = function() {
125126
//var tz = require('jstimezonedetect').determine(); // For the online version
126-
var tz = require('jstz').determine();
127-
return (typeof (tz) === 'undefined') ? '' : tz.name();
127+
return (typeof (tz) === 'undefined') ? '' : tz.name();
128128
}
129129

130130
/**

src/js/lib/helpers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
*/
3434
;(function () {
3535

36-
var identifiers = require('identifiers');
36+
var identifiers = require('./identifiers.js');
3737

3838
var object = typeof module.exports != 'undefined' ? module.exports : this; // For eventual node.js environment support
3939

src/js/lib/sha1.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
;(function(){
2222

23-
var helpers = require('helpers');
23+
var helpers = require('./helpers.js');
2424

2525
var object = typeof module.exports != 'undefined' ? module.exports : this; // For eventual node.js environment support
2626

src/js/payload.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
var object = typeof module.exports != 'undefined' ? module.exports : this; // For eventual node.js environment support
3838

39-
var identifiers = require('identifiers');
39+
var identifiers = require('./lib/identifiers.js');
4040

4141
var json2 = require('JSON');
4242

src/js/queue.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
;(function() {
3636

37-
var identifiers = require('identifiers');
37+
var identifiers = require('./lib/identifiers.js');
3838

3939
var object = typeof module.exports != 'undefined' ? module.exports : this; // For eventual node.js environment support
4040

src/js/snowplow.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,10 @@
7474
;(function() {
7575

7676
// Load all our modules (at least until we fully modularize & remove grunt-concat)
77-
var identifiers = require('identifiers');
78-
var tracker = require('tracker');
79-
var helpers = require('helpers');
80-
var queue = require('queue');
77+
var identifiers = require('./lib/identifiers.js');
78+
var tracker = require('./tracker.js');
79+
var helpers = require('./lib/helpers.js');
80+
var queue = require('./queue.js');
8181

8282
var object = typeof module.exports != 'undefined' ? module.exports : this; // For eventual node.js environment support
8383

src/js/tracker.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@
3434

3535
;(function() {
3636

37-
var identifiers = require('identifiers');
38-
var helpers = require('helpers');
39-
var sha1 = require('sha1');
40-
var cookie = require('cookie');
41-
var detectors = require('detectors');
42-
var payload = require('payload');
37+
var identifiers = require('./lib/identifiers.js');
38+
var helpers = require('./lib/helpers.js');
39+
var sha1 = require('./lib/sha1.js');
40+
var cookie = require('./lib/cookie.js');
41+
var detectors = require('./lib/detectors.js');
42+
var payload = require('./payload.js');
4343
var json2 = require('JSON');
4444

4545
var object = typeof module.exports != 'undefined' ? module.exports : this; // For eventual node.js environment support

0 commit comments

Comments
 (0)