Skip to content

Commit 1cfbb2c

Browse files
committed
Removed context vendor and event vendor from the querystring (snowplow#180) (snowplow#138)
1 parent edda123 commit 1cfbb2c

4 files changed

Lines changed: 2 additions & 9 deletions

File tree

CHANGELOG

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ Passed tracker namespace through to collector in Tracker Protocol (#126)
1919
Moved to argmap-style tracker creation with 'newTracker' (#132)
2020
Added support for cookie namespacing (#131)
2121
Added new tag which allows queue to be renamed (#130)
22-
Added event vendor parameter sent through on querystring (#138)
2322
Started rigorously checking whether a page is cached by Yahoo (#142)
2423
Upgraded Intern to 1.5.0 (#119)
2524
Fixed link to code climate button in README.md (#149)
@@ -33,7 +32,6 @@ Removed ads/sync.html (#182)
3332
Updated ads/async.html (#183)
3433
Added pageUnloadTimer option to argmap (#171)
3534
Added event vendor as argument to trackUnstructEvent (#157)
36-
Added custom context vendor configuration option (#180)
3735
Removed type hints from unstructured events and custom contexts (#163)
3836
Added hardcoded schema to custom context arrays (#199)
3937
Added hardcoded schema to unstructured events (#196)

examples/web/async-medium.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888

8989
// Only the "uri" tracker will track the Viewed Product event
9090
window.new_name_here('trackUnstructEvent:uri', {
91-
schema: 'com.acme_company/viewed_product/json/5.0.0',
91+
schema: 'com.acme_company/viewed_product/json/5-0-0',
9292
data: {
9393
productId: 'ASO01043',
9494
category: 'Dresses',

examples/web/async-small.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
function viewProduct() {
7272
alert("Viewing a product");
7373
window.snowplow('trackUnstructEvent', {
74-
schema: 'com.acme_company/viewed_product/json/5.0.0',
74+
schema: 'com.acme_company/viewed_product/json/5-0-0',
7575
data: {
7676
productId: 'ASO01043',
7777
category: 'Dresses',

src/js/tracker.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,6 @@
579579
var sb = payload.payloadBuilder(configEncodeBase64);
580580
sb.add('e', 'pv'); // 'pv' for Page View
581581
sb.add('page', pageTitle);
582-
sb.add('evn', configDefaultVendor);
583582
sb.addJson('cx', 'co', completeContext(context));
584583
var request = getRequest(sb);
585584
sendRequest(request, configTrackerPause);
@@ -642,7 +641,6 @@
642641
sb.addRaw('pp_max', maxXOffset); // Global
643642
sb.addRaw('pp_miy', minYOffset); // Global
644643
sb.addRaw('pp_may', maxYOffset); // Global
645-
sb.add('evn', configDefaultVendor);
646644
sb.addJson('cx', 'co', completeContext(context));
647645
resetMaxScrolls();
648646
var request = getRequest(sb);
@@ -667,7 +665,6 @@
667665
sb.add('se_la', label);
668666
sb.add('se_pr', property);
669667
sb.add('se_va', value);
670-
sb.add('evn', configDefaultVendor);
671668
sb.addJson('cx', 'co', completeContext(context));
672669
var request = getRequest(sb);
673670
sendRequest(request, configTrackerPause);
@@ -722,7 +719,6 @@
722719
sb.add('tr_st', state);
723720
sb.add('tr_co', country);
724721
sb.add('tr_cu', currency);
725-
sb.add('evn', configDefaultVendor);
726722
sb.addJson('cx', 'co', completeContext(context));
727723
var request = getRequest(sb);
728724
sendRequest(request, configTrackerPause);
@@ -751,7 +747,6 @@
751747
sb.add('ti_pr', price);
752748
sb.add('ti_qu', quantity);
753749
sb.add('ti_cu', currency);
754-
sb.add('evn', configDefaultVendor);
755750
sb.addJson('cx', 'co', completeContext(context));
756751
var request = getRequest(sb);
757752
sendRequest(request, configTrackerPause);

0 commit comments

Comments
 (0)