Skip to content

Commit 9bf4e3d

Browse files
committed
fix review comments
1 parent 88414fb commit 9bf4e3d

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

build/modern-loader.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,13 @@ module.exports = async (id, content, onwarn=null) => {
9898
// so we should only end up with a single result (checked below).
9999
preserveModules: true,
100100
onwarn,
101+
treeshake: false, // we don't want any code thrown away in dev
101102
});
102103

103104
const out = await bundle.generate({
104105
name: id,
105106
format: 'es',
106107
sourcemap: true,
107-
//treeshake: false, // we want to cache the results
108108
});
109109

110110
if (out.output.length !== 1) {

static/scenes/modvil/elements/modvil-tracker.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ common.preload.images(
3838
const focusTimeoutDelay = 20 * 1000; // refocus on Santa after this much inactivity
3939

4040

41-
// This
41+
// The jitter ratio is stored for the current browser window, so if users reload, they'll see Santa
42+
// "jittered" by the same amount. This lets us randomly skew Santa through the route via Firebase,
43+
// in case Maps is having a bad time.
4244
if (!localStorage['routeJitter']) {
4345
localStorage['routeJitter'] = (Math.random() * 2) - 1; // between [-1,+1]
4446
}

0 commit comments

Comments
 (0)